[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdevplatform/util
From:       Andreas Pakulat <apaku () gmx ! de>
Date:       2008-06-04 23:05:43
Message-ID: 1212620743.791587.10373.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 816919 by apaku:

Yeah, as the warning said, just changing the order of deletion fixes the crash
and is actually the right thing to do.


 M  +1 -5      commandexecutor.cpp  


--- trunk/KDE/kdevplatform/util/commandexecutor.cpp #816918:816919
@@ -80,12 +80,8 @@
 
 CommandExecutor::~CommandExecutor()
 {
-#warning Not sure this is correct, maybe just switching the first two deletes works as well
-    d->m_process->kill();
-    d->m_process->waitForFinished( 3000 );
-
-    delete d->m_lineMaker;
     delete d->m_process;
+    delete d->m_lineMaker;
     delete d;
 }
 
[prev in list] [next in list] [prev in thread] [next in thread]