[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdevplatform/plugins/standardoutputview
From:       Andreas Pakulat <apaku () gmx ! de>
Date:       2008-06-04 23:00:42
Message-ID: 1212620442.054808.10113.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 816916 by apaku:

Remove the (now uneeded) check for empty-ness of the list and instead make sure
that all toolviews for a given tooldata are raised as those might be in
different area's actually.


 M  +7 -6      standardoutputview.cpp  


--- trunk/KDE/kdevplatform/plugins/standardoutputview/standardoutputview.cpp \
#816915:816916 @@ -41,6 +41,7 @@
 #include <sublime/view.h>
 #include <sublime/area.h>
 #include <sublime/controller.h>
+#include <sublime/document.h>
 
 #include "toolviewdata.h"
 
@@ -195,13 +196,13 @@
 {
     foreach( int _id, toolviews.keys() )
     {
-#warning This fix is wrong, the list of views shouldn't be empty!
-        if( toolviews.value( _id )->outputdata.contains( id ) && !toolviews.value( \
_id )->views.isEmpty()) +        if( toolviews.value( _id )->outputdata.contains( id \
) )  {
-            Sublime::View* v = toolviews.value( _id )->views.at(0);
-            OutputWidget* w = qobject_cast<OutputWidget*>( v->widget() );
-            w->raiseOutput( id );
-            v->requestRaise();
+            foreach( Sublime::View* v, toolviews.value( _id )->views ) {
+                OutputWidget* w = qobject_cast<OutputWidget*>( v->widget() );
+                w->raiseOutput( id );
+                v->requestRaise();
+            }
         }
     }
 }


[prev in list] [next in list] [prev in thread] [next in thread]