[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kdeui/icons
From:       Michael Pyne <mpyne () purinchu ! net>
Date:       2008-06-01 3:12:54
Message-ID: 1212289974.388587.29139.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 815057 by mpyne:

Disable the on disk pixmap cache (affects icon caching) as this causes crashes for some use cases, as
discussed on bug 160284.  There are two known causes:

1. Alignment of mmap()'ed data is off, which on some architectures results in a SIGBUS.
2. We can also receive SIGBUS for trying to access mmap()'ed pages where the underlying file has been
   truncated, which has also been an issue.

I'm working on making the code properly handle the SIGBUS signal which we can receive if our mmap()'ed
cache is deleted from under us.  I will also fix a separate issue with alignment of the mmap()'ed data if
I can fix the SIGBUS issue.

CCBUG:160284


 M  +2 -1      kpixmapcache.cpp  


--- trunk/KDE/kdelibs/kdeui/icons/kpixmapcache.cpp #815056:815057
@@ -53,7 +53,8 @@
 
 //#define DISABLE_PIXMAPCACHE
 #if defined HAVE_MMAP && !defined Q_WS_WIN
-#define USE_MMAP
+// Disabled due to bug 160284 while awaiting proper handling of SIGBUS.
+//#define USE_MMAP
 #endif
 
 #define KPIXMAPCACHE_VERSION 0x000206
[prev in list] [next in list] [prev in thread] [next in thread]