[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdeedu/marble
From:       Jens-Michael Hoffmann <jensmh () gmx ! de>
Date:       2008-06-01 0:14:20
Message-ID: 1212279260.976447.24058.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 815036 by jmhoffmann:

    - Fix valgrind error: Conditional jump or move depends on uninitialised
      value(s) in CompassFloatItem::needsUpdate.
    - Use Q_DISABLE_COPY.
    - Add api doc for m_polarity.



 M  +10 -0     ChangeLog  
 M  +3 -1      src/plugins/marble/compass/CompassFloatItem.cpp  
 M  +4 -0      src/plugins/marble/compass/CompassFloatItem.h  


--- trunk/KDE/kdeedu/marble/ChangeLog #815035:815036
@@ -1,3 +1,13 @@
+2008-06-01  Jens-Michael Hoffmann  <jensmh@gmx.de>
+
+    * src/plugins/marble/compass/CompassFloatItem.h:
+    * src/plugins/marble/compass/CompassFloatItem.cpp:
+
+    - Fix valgrind error: Conditional jump or move depends on uninitialised
+      value(s) in CompassFloatItem::needsUpdate.
+    - Use Q_DISABLE_COPY.
+    - Add api doc for m_polarity.
+
 2008-06-01  Inge Wallin  <inge@lysator.liu.se>
 
 	Fix paintBase and setActiveArea for the Mercator projection.
--- trunk/KDE/kdeedu/marble/src/plugins/marble/compass/CompassFloatItem.cpp #815035:815036
@@ -23,7 +23,9 @@
 
 
 CompassFloatItem ::CompassFloatItem ( const QPointF &point, const QSizeF &size )
-    : MarbleAbstractFloatItem( point, size )
+    : MarbleAbstractFloatItem( point, size ),
+      m_compass(),
+      m_polarity( 0 )
 {
     m_svgobj = new QSvgRenderer( MarbleDirs::path( "svg/compass.svg" ),
                                  this );
--- trunk/KDE/kdeedu/marble/src/plugins/marble/compass/CompassFloatItem.h #815035:815036
@@ -61,8 +61,12 @@
     bool renderFloatItem( GeoPainter *painter, ViewportParams *viewport, GeoSceneLayer * layer = 0 );
 
  private:
+    Q_DISABLE_COPY( CompassFloatItem )
+
     QSvgRenderer  *m_svgobj;
     QPixmap        m_compass;
+
+    /// allowed values: -1, 0, 1; default here: 0. FIXME: Declare enum
     int            m_polarity;
 };
 
[prev in list] [next in list] [prev in thread] [next in thread]