[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/apps/konqueror/src
From:       Eduardo Robles Elvira <edulix () gmail ! com>
Date:       2008-05-31 23:34:12
Message-ID: 1212276852.479827.22790.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 815027 by edulix:

Fixing *huge* memory leak in konqueror: in KonqView::~KonqView() we were just not \
deleting the HistoryEntries. No kidding. Each view can contain *a lot* of \
HistoryEntries, and each entry contains lots of data: url, locationBarURL, title, \
buffer, postData, etc. All that was being leaked when deleting konqviews (i.e. \
closing a tab).

Thanks pinotree for helping out with valgrind and giving me the valgrind output, you \
rock!

CCMAIL:kfm-devel@kde.org
CCMAIL:faure@kde.org



 M  +3 -0      konqview.cpp  


--- trunk/KDE/kdebase/apps/konqueror/src/konqview.cpp #815026:815027
@@ -131,6 +131,9 @@
 
     delete m_pPart;
   }
+  
+  qDeleteAll( m_lstHistory );
+  m_lstHistory.clear();
 
   setRun( 0L );
   //kDebug(1202) << this << "done";


[prev in list] [next in list] [prev in thread] [next in thread]