[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdesdk/kcachegrind/kcachegrind
From:       Josef Weidendorfer <Josef.Weidendorfer () gmx ! de>
Date:       2008-05-30 19:41:09
Message-ID: 1212176469.750847.9481.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 814592 by weidendo:

KCachegrind: restore correct field drawing in RectDrawing

I still do not have a good solution for bug 161276.
If I change the drawing order to first draw the percentage
into call graph nodes, they always will be shown. But then,
in the compact mode, the symbols are not shown, which IMHO
is worse than not showing the percentage.
As this all very much depends on the size/type of the system
font, the best solution probably is to be able to freely
resize the node rectangles...


 M  +4 -4      treemap.cpp  


--- trunk/KDE/kdesdk/kcachegrind/kcachegrind/treemap.cpp #814591:814592
@@ -486,8 +486,8 @@
   int height  = (rotate ? r.width() : r.height());
   int lines   = height / h;
 
-  // stop if we have no space available
-  if (lines<1) lines = 1/*return false*/;
+  // stop if there is no space available
+  if (lines<1) return false;
 
   // calculate free space in first line (<unused>)
   int pos = dp->position(f);
@@ -755,7 +755,7 @@
     if (!isBottom && (pixY>y)) y = pixY;
   }
 
-/*  if (origLines > lines) {
+  if (origLines > lines) {
     // if only 1 line written, do not reset _used* vars
     if (lines - origLines >1) {
       if (isBottom)
@@ -767,7 +767,7 @@
     // take back one line
     y = isBottom ? (y+h) : (y-h);
     if (used) *used = w;
-  }*/
+  }
 
   // update free space
   if (!isBottom) {
[prev in list] [next in list] [prev in thread] [next in thread]