[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepimlibs/kioslave/imap4
From:       David Faure <faure () kde ! org>
Date:       2008-05-30 10:42:59
Message-ID: 200805301243.00739.faure () kde ! org
[Download RAW message or body]

On Friday 30 May 2008, Dirk Mueller wrote:
> > > Is this something Krazy should check for?
> >
> > For constant int values, at least, yes.
> 
> #define's might also cause issues in --enable-final build mode (which we don't 
> support anymore, afaik, so its not a big issue).

We do support enable final - at least the cmake buildsystem does support it, and I fixed kdelibs
for it recently.

cmake -DKDE4_ENABLE_FINAL:BOOL=ON

> I wouldn't deprecate #defines  
> completely, so I don't think a krazy check is appropriate here. The reason for 
> that is that static ints generate massively different code in -O0 vs -O2 (in 
> case you try to hunt a bug) and also degrade performance for non-integral 
> types (floats, double constants, long long ints and similar). 

Really? a static double is worse than a #define which will basically copy/paste that
double everywhere where the code uses that value? compilers are strange...

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]