[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdenetwork/kopete/protocols/groupwise
From:       Dirk Mueller <mueller () kde ! org>
Date:       2008-05-30 7:02:40
Message-ID: 200805300902.40783.mueller () kde ! org
[Download RAW message or body]

On Thursday 08 May 2008, Will Stephenson wrote:

> Use QByteArrays instead of QLatin1Strings, since QBA has implicit sharing

as long as you only use it for wrapping string literals (which you do, as far 
as I can see) I don't see why you need implicit sharing? Out of curiousity, 
why is that needed? A pointer to a string literal is also always implicitely 
shared. Converting it to a QByteArray means deep copy, atomic refcounting and 
therefore a comparatively big performance degradation. 

Greetings,
Dirk

>
>  M  +1 -1      libgroupwise/coreprotocol.cpp
>  M  +89 -109   libgroupwise/gwfield.cpp
>  M  +83 -88    libgroupwise/gwfield.h
>  M  +3 -8      libgroupwise/responseprotocol.cpp
>  M  +1 -1      libgroupwise/tasks/logintask.cpp
>  M  +1 -1      libgroupwise/tasks/logintask.h
>  M  +1 -1      libgroupwise/tasks/searchusertask.cpp
>  M  +3 -3      ui/gwsearch.cpp


[prev in list] [next in list] [prev in thread] [next in thread]