[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/phonon/4.2/phonon trunk/kdesupport/phonon/phonon
From:       Bernhard Beschow <bbeschow () cs ! tu-berlin ! de>
Date:       2008-05-26 20:31:24
Message-ID: 200805262231.24771.bbeschow () cs ! tu-berlin ! de
[Download RAW message or body]

Am Montag 26 Mai 2008 21:15:01 schrieb Matthias Kretz:
> On Monday 26 May 2008, Bernhard Beschow wrote:
> > Am Montag 26 Mai 2008 19:06:44 schrieb Matthias Kretz:
> > > SVN commit 812935 by mkretz:
> > > 
> > > revert
> > > 
> > > > SVN commit 798057 by beschow:
> > > > 
> > > > Fix layout direction in vertical mode.
> > > 
> > > to fix layout direction in vertical mode. Why is it a fix to put the mute
> > > button/icon below the slider?
> > 
> > IMO, there are two reasons:
> > 1) It is more intuitive when the mute button is at the 0%-position. This
> > was already the case when the slider was layed out horizontally.
> > 2) In 
> > vertical mode, however, it was at the 100%-position. Whenever it is used in
> > different apps with different layout direction or even worse, when the
> > slider's direction can be changed dynamically, this may be percieved as an
> > inconsistency.
> > 
> > Do you agree?
> 
> The reason I want to have the mute button on top in vertical mode is because 
> real mixers (mixing consoles) have it that way. I've never seen a mute button 
> below the fader.
> 
> Also KMix has the mute button above the slider.
> 
> And as left-to-right is equivalent to top to bottom (well, at least in the LTR 
> world) the mute button has to be at the left for horizontal mode.

Okay I see, sorry for messing up SVN...

So what about adding an attibute to specify the behavior depending on the scenario? The default could be \
just like you explained.

Regards,
Bernhard


[prev in list] [next in list] [prev in thread] [next in thread]