[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/workspace/plasma/plasma
From:       Chani Armitage <chanika () gmail ! com>
Date:       2008-05-23 4:38:32
Message-ID: 1211517512.116236.21740.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 811456 by chani:

fun fact: in c++, (-1 % foo) == -1


 M  +8 -2      desktopview.cpp  


--- trunk/KDE/kdebase/workspace/plasma/plasma/desktopview.cpp #811455:811456
@@ -337,14 +337,20 @@
 {
     QList<Plasma::Containment*> containments = containment()->corona()->containments();
     int start = containments.indexOf(containment());
-    int i = (start - 1) % containments.size();
+    //fun fact: in c++, (-1 % foo) == -1
+    int i = start - 1;
+    if (i < 0) {
+        i += containments.size();
+    }
     //FIXME this is a *horrible* way of choosing a "previous" containment.
     while (i != start) {
         if (containments.at(i)->containmentType() != Plasma::Containment::PanelContainment &&
             containments.at(i)->screen() == -1) {
             break;
         }
-        i = (i - 1) % containments.size();
+        if (--i < 0) {
+            i += containments.size();
+        }
     }
 
     Plasma::Containment *c = containments.at(i);
[prev in list] [next in list] [prev in thread] [next in thread]