[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdepim/akregator/plugins/onlinesync
From:       Frank Osterfeld <frank.osterfeld () kdemail ! net>
Date:       2008-05-18 10:03:24
Message-ID: 1211105004.348250.11936.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 809070 by osterfeld:

minor fixes (constness, explicit, string capitalization)

 M  +1 -1      sync/googlereader.h  
 M  +1 -1      sync/opml.h  
 M  +5 -5      sync/subscriptionlist.cpp  
 M  +6 -6      sync/subscriptionlist.h  
 M  +1 -1      ui/configurationdialog.cpp  
 M  +2 -2      ui/configurationdialog.h  
 M  +1 -1      ui/configurationdialogadd.cpp  
 M  +2 -2      ui/configurationdialogadd.h  


--- trunk/KDE/kdepim/akregator/plugins/onlinesync/sync/googlereader.h #809069:809070
@@ -16,7 +16,7 @@
     Q_OBJECT
 
  public:
-    GoogleReader(const KConfigGroup& configgroup);
+    explicit GoogleReader(const KConfigGroup& configgroup);
     ~GoogleReader();
     SubscriptionList * getSubscriptionList() const;
     void load();
--- trunk/KDE/kdepim/akregator/plugins/onlinesync/sync/opml.h #809069:809070
@@ -16,7 +16,7 @@
     Q_OBJECT
 
  public:
-    Opml(const KConfigGroup& configgroup);
+    explicit Opml(const KConfigGroup& configgroup);
     ~Opml();
     SubscriptionList * getSubscriptionList() const;
     void load();
--- trunk/KDE/kdepim/akregator/plugins/onlinesync/sync/subscriptionlist.cpp \
#809069:809070 @@ -39,7 +39,7 @@
     _catListFull.removeAt(index);
 }
 
-SubscriptionList * SubscriptionList::compare(SubscriptionList * iOther, \
ComparisonType diffType, RemovePolicy removePolicy) +SubscriptionList * \
SubscriptionList::compare(SubscriptionList * iOther, ComparisonType diffType, \
RemovePolicy removePolicy) const  {
     kDebug();
 
@@ -92,7 +92,7 @@
     return diffList;
 }
 
-int SubscriptionList::indexOf(const QString& iRss, const QString& iName, const \
QString& iCat) +int SubscriptionList::indexOf(const QString& iRss, const QString& \
iName, const QString& iCat) const  {
     for (int i=0; i<this->count(); i++) {
         QString m_rss = this->getRss(i);
@@ -104,7 +104,7 @@
     return -1;
 }
 
-int SubscriptionList::indexOf(const QString& iRss) 
+int SubscriptionList::indexOf(const QString& iRss) const
 {
     for (int i=0; i<this->count(); i++) {
         QString m_rss = this->getRss(i);
@@ -116,12 +116,12 @@
     return -1;
 }
 
-int SubscriptionList::count() 
+int SubscriptionList::count() const
 {
     return _rssList.size();
 }
 
-int SubscriptionList::countRss(const QString& iRss) 
+int SubscriptionList::countRss(const QString& iRss) const
 {
     return _rssList.count(iRss);
 }
--- trunk/KDE/kdepim/akregator/plugins/onlinesync/sync/subscriptionlist.h \
#809069:809070 @@ -26,16 +26,16 @@
         Simple, Full
     };
 
-    SubscriptionList * compare(SubscriptionList * iOther, ComparisonType diffType, \
                RemovePolicy removePolicy=Nothing);
-    bool rssExist(const QString& iRss,const QString& iName,const QString& iCat);
+    SubscriptionList * compare(SubscriptionList * iOther, ComparisonType diffType, \
RemovePolicy removePolicy=Nothing) const; +    bool rssExist(const QString& \
iRss,const QString& iName,const QString& iCat) const;  QString getRss(int index) \
const;  QString getName(int index) const;
     QString getCat(int index, CategoryFormat format=Simple) const;
 
-    int count();
-    int countRss(const QString& iRss);
-    int indexOf(const QString& iRss, const QString& iName, const QString& iCat);
-    int indexOf(const QString& iRss);
+    int count() const;
+    int countRss(const QString& iRss) const;
+    int indexOf(const QString& iRss, const QString& iName, const QString& iCat) \
const; +    int indexOf(const QString& iRss) const;
 
 
 
--- trunk/KDE/kdepim/akregator/plugins/onlinesync/ui/configurationdialog.cpp \
#809069:809070 @@ -18,7 +18,7 @@
     ui->setupUi(widget);
     setMainWidget( widget );
 
-    setCaption( i18n("Online reader") );
+    setCaption( i18n("Online Reader") );
 
     QTimer::singleShot( 0, this, SLOT(slotDelayedInit()) );
 }
--- trunk/KDE/kdepim/akregator/plugins/onlinesync/ui/configurationdialog.h \
#809069:809070 @@ -19,9 +19,9 @@
     Q_OBJECT
     public:
         // Constructor if the dialog must be created
-        ConfigurationDialog( QWidget *parent=0 );
+        explicit ConfigurationDialog( QWidget *parent=0 );
         // Constructor if the dialog must not be created
-        ConfigurationDialog( Ui::ConfigurationDialog * configUi , QWidget * parent \
); +        explicit ConfigurationDialog( Ui::ConfigurationDialog * configUi , \
QWidget * parent=0 );  ~ConfigurationDialog();
 
     private:
--- trunk/KDE/kdepim/akregator/plugins/onlinesync/ui/configurationdialogadd.cpp \
#809069:809070 @@ -97,7 +97,7 @@
     }
 }
 
-void ConfigurationDialogAdd::load( const KConfigGroup group )
+void ConfigurationDialogAdd::load( const KConfigGroup& group )
 {
     kDebug();
     _baseconfigname = group.name();
--- trunk/KDE/kdepim/akregator/plugins/onlinesync/ui/configurationdialogadd.h \
#809069:809070 @@ -19,9 +19,9 @@
 {
     Q_OBJECT
     public:
-        ConfigurationDialogAdd( QWidget *parent=0 );
+        explicit ConfigurationDialogAdd( QWidget *parent=0 );
         ~ConfigurationDialogAdd();
-        void load( const KConfigGroup group );
+        void load( const KConfigGroup &group );
 
     private:
         Ui::ConfigurationDialogAdd * ui;


[prev in list] [next in list] [prev in thread] [next in thread]