[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/workspace/plasma/applets/digital-clock
From:       Marco Martin <notmart () gmail ! com>
Date:       2008-05-12 21:33:07
Message-ID: 200805122333.09565.notmart () gmail ! com
[Download RAW message or body]

On Monday 12 May 2008, Robert Knight wrote:
> SVN commit 807006 by knight:
>
> Revert size policy change.  Reset size policy back to Minimum,Minimum until
> it is fixed to work on both horizontal and vertical panels.

maybe could make sense something like that in this case?

Cheers,
Marco Martin

> CCMAIL:sebas@kde.org
>
>
>  M  +1 -1      clock.cpp
>
>
> --- trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clock.cpp
> #807005:807006 @@ -61,7 +61,7 @@
>  {
>      setHasConfigurationInterface(true);
>      resize(150, 75);
> -    setSizePolicy(QSizePolicy::Maximum,QSizePolicy::Maximum);
> +    setSizePolicy(QSizePolicy::Minimum,QSizePolicy::Minimum);
>  }
>
>  void Clock::init()



["niceclocksizing.diff" (text/x-diff)]

Index: clock.cpp
===================================================================
--- clock.cpp	(revision 806887)
+++ clock.cpp	(working copy)
@@ -61,7 +61,6 @@
 {
     setHasConfigurationInterface(true);
     resize(150, 75);
-    setSizePolicy(QSizePolicy::Maximum,QSizePolicy::Maximum);
 }
 
 void Clock::init()
@@ -113,6 +112,19 @@
             setMinimumHeight((int)geometry().width() / aspect);
         }
     }
+
+    if (constraints & Plasma::FormFactorConstraint) {
+        switch (formFactor()) {
+        case Plasma::Horizontal:
+            setSizePolicy(QSizePolicy::Minimum, QSizePolicy::Expanding);
+            break;
+        case Plasma::Vertical:
+            setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Minimum);
+            break;
+        default:
+            setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Preferred);
+        }
+    }
 }
 
 void Clock::updateToolTipContent() {


[prev in list] [next in list] [prev in thread] [next in thread]