[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    playground/pim/kblogger
From:       Antonio Aloisio <antonio.aloisio () gmail ! com>
Date:       2008-05-07 23:00:23
Message-ID: 1210201223.660219.4226.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 805241 by aloisio:

Fix. All media are showed in the mediaList of the composer.

 M  +3 -1      TODO  
 M  +0 -5      src/media/medialistview.cpp  
 M  +9 -4      src/media/medialistwidget.cpp  
 M  +1 -0      src/media/medialistwidget.h  


--- trunk/playground/pim/kblogger/TODO #805240:805241
@@ -20,6 +20,7 @@
         and seperate logical steps in code with newlines
     - fix english mistakes in the strings [duns_s,gnuton] [in progress..]
     - merge/split classes [duns_s,gnuton][in progress]
+      - separe class MediaListWidget and MediaList from the same file [gnuton]
     - converts QDialog in KDialog. [duns_s,gnuton][in progress]
       - do that for the AddLinkWidget, UploadMediaManager..., too [gnuton]
     - merge/split classes where it's needed.
@@ -34,7 +35,8 @@
      - rename medialist.h/cpp to medialistwidget.h/cpp [gnuton] [done]
      - rename itemlist.h/cpp to itemslistwidget.h/cpp [gnuton]
      - add thumbnail regexp for other blog systems. [gnuton, duns]
- 
+     - fix compilation warnings 
+
 Code review for classes:
 
 In general I propose to split classes like this, too:
--- trunk/playground/pim/kblogger/src/media/medialistview.cpp #805240:805241
@@ -92,11 +92,6 @@
         Q_ASSERT(media);
         mMediaListWidget->appendMedia(media);
     }
-    /*
-    for (int i = 0; i < media.size(); ++i) {
-        if (media.at(i))
-            mMediaListWidget->appendMedia(media.at(i));
-    }*/
 }
 
 } //namespace
--- trunk/playground/pim/kblogger/src/media/medialistwidget.cpp #805240:805241
@@ -66,9 +66,10 @@
 
 void MediaListWidget::appendMedia( Media* kbMedia )
 {
-    kDebug();
+    kDebug() << "Name:" << kbMedia->name() << endl
+             << "Cached FileName:" <<  kbMedia->cachedFilename() << endl;
     Q_ASSERT( kbMedia );
-
+   
     //Sets status string
     QString status;
 
@@ -195,7 +196,10 @@
 void MediaList::appendMedia(Media* kbMedia)
 {
     kDebug() << "Media name:" << kbMedia->name();
-    if ( kbMedia->checksum() == 0 ) return;
+    if ( kbMedia->checksum() == 0 ){
+        kWarning() << "Media with empty data skipped";
+        return;
+    }
     MediaListWidget::appendMedia( kbMedia );
 
     //
@@ -360,7 +364,8 @@
 QList<Media*> MediaList::getMediaList()
 {
     kDebug();
-    return mMediaMap.values();
+    //return mMediaMap.values();
+    return mSortedMediaList;
 }
 
 void MediaList::removeLocalItem( Media *media )
--- trunk/playground/pim/kblogger/src/media/medialistwidget.h #805240:805241
@@ -66,6 +66,7 @@
     QMap<QTreeWidgetItem*, Media*> mMediaMap; //NOTE use QHash?
 
     //Store Media ptr sorted by creation
+    //NOTE: This list should contain media fullsize ptr before its thumbnail.
     QList<Media*> mSortedMediaList;
 };
 
[prev in list] [next in list] [prev in thread] [next in thread]