[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepimlibs/kioslave/imap4
From:       David Faure <dfaure () kdab ! net>
Date:       2008-05-07 21:04:56
Message-ID: 200805072304.58911.dfaure () kdab ! net
[Download RAW message or body]

On Wednesday 07 May 2008, Allen Winter wrote:
> On Tuesday 06 May 2008 14:47:59 Jakub Stachowski wrote:
> > SVN commit 804674 by qbast:
> >
> > Use static const instead of #define
> >
> Curious minds want to know. :)
> Is this because we want to avoid the preprocessor potentially
> screwing things up? 

No, both work, but #define is ugly :)
static const int, OTOH, is not a preprocessor hack and gives some type safety.

> Is this something Krazy should check for? 

For constant int values, at least, yes.

-- 
David Faure, faure@kde.org, dfaure@klaralvdalens-datakonsult.se
KDE/KOffice developer, Qt consultancy projects
Klarälvdalens Datakonsult AB, Platform-independent software solutions

[prev in list] [next in list] [prev in thread] [next in thread]