[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepimlibs/kioslave/imap4
From:       Marc Mutz <marc () kdab ! net>
Date:       2008-05-06 13:30:49
Message-ID: 200805061530.51822.marc () kdab ! net
[Download RAW message or body]

On Sunday May 4 2008 12:32, Jakub Stachowski wrote:
> +#define IMAP_PORT 143
> +#define IMAPS_PORT 993

This is C++. Please use
  static const int ImapPort = 143;
  static const int ImapsPort = 993;
instead of preprocessor defines.

Thanks,
Marc

-- 
Marc Mutz - marc@kdab.com, mutz@kde.org - Klarälvdalens Datakonsult AB
Platform-independent software solutions - www.kdab.com info@kdab.com

[prev in list] [next in list] [prev in thread] [next in thread]