[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kdeui/widgets
From:       Jakob Petsovits <jpetso () gmx ! at>
Date:       2008-05-01 10:29:45
Message-ID: 1209637785.621239.2714.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 802936 by jpetso:

I know that formatting-only changes in other peoples' code
should be avoided, but this formatting is a bug. A look into
the 3.5 version reveals that the "x += ..." statement actually
doesn't belong to the if() above, and the current code has
been parsed correctly (just the indentation was bad).


 M  +5 -4      ktabwidget.cpp  


--- trunk/KDE/kdelibs/kdeui/widgets/ktabwidget.cpp #802935:802936
@@ -264,11 +264,12 @@
 
     int lw = fm.width( newTitle );
     int iw = 0;
-    if ( !tabBar()->tabIcon( i ).isNull() )
+    if ( !tabBar()->tabIcon( i ).isNull() ) {
       iw = tabBar()->tabIcon( i ).pixmap( style()->pixelMetric( \
                QStyle::PM_SmallIconSize ), QIcon::Normal ).width() + 4;
-      x += ( tabBar()->style()->sizeFromContents( QStyle::CT_TabBarTab, 0L,
-           QSize( qMax( lw + hframe + iw, QApplication::globalStrut().width() ), 0 \
                ),
-           this ) ).width();
+    }
+    x += ( tabBar()->style()->sizeFromContents( QStyle::CT_TabBarTab, 0L,
+         QSize( qMax( lw + hframe + iw, QApplication::globalStrut().width() ), 0 ),
+         this ) ).width();
   }
 
   return x;


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic