[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: KDE/kdebase/workspace/plasma/applets
From: Davide Bettio <davbet () aliceposta ! it>
Date: 2008-04-27 11:36:38
Message-ID: 1209296198.993479.11337.nullmailer () svn ! kde ! org
[Download RAW message or body]
SVN commit 801663 by bettio:
API REVIEW: constraintsUpdated() -> constraintsEvent()
M +3 -2 analog-clock/clock.cpp
M +1 -1 analog-clock/clock.h
M +1 -1 battery/battery.cpp
M +1 -1 battery/battery.h
M +1 -1 devicenotifier/devicenotifier.cpp
M +1 -1 devicenotifier/devicenotifier.h
M +3 -2 icon/icon.cpp
M +1 -1 icon/icon.h
M +1 -1 kickoff/applet/applet.cpp
M +1 -1 kickoff/applet/applet.h
M +1 -1 lock_logout/lockout.cpp
M +1 -1 lock_logout/lockout.h
M +1 -1 pager/pager.cpp
M +1 -1 pager/pager.h
M +1 -1 systemtray/systemtray.cpp
M +1 -1 systemtray/systemtray.h
M +1 -1 tasks/tasks.cpp
M +1 -1 tasks/tasks.h
M +1 -1 trash/trash.cpp
M +1 -1 trash/trash.h
--- trunk/KDE/kdebase/workspace/plasma/applets/analog-clock/clock.cpp #801662:801663
@@ -89,7 +89,7 @@
}
}
-void Clock::constraintsUpdated(Plasma::Constraints constraints)
+void Clock::constraintsEvent(Plasma::Constraints constraints)
{
if (constraints & Plasma::FormFactorConstraint) {
setBackgroundHints(NoBackground);
@@ -171,7 +171,8 @@
}
connectToEngine();
- constraintsUpdated(Plasma::AllConstraints);
+ //TODO: why we don't call updateConstraints()?
+ constraintsEvent(Plasma::AllConstraints);
emit configNeedsSaving();
}
--- trunk/KDE/kdebase/workspace/plasma/applets/analog-clock/clock.h #801662:801663
@@ -53,7 +53,7 @@
void init();
void paintInterface(QPainter *painter, const QStyleOptionGraphicsItem \
*option, const QRect &contentsRect); void setPath(const QString&);
- void constraintsUpdated(Plasma::Constraints constraints);
+ void constraintsEvent(Plasma::Constraints constraints);
QPainterPath shape() const;
public slots:
--- trunk/KDE/kdebase/workspace/plasma/applets/battery/battery.cpp #801662:801663
@@ -120,7 +120,7 @@
kDebug() << battery_sources.size();
}
-void Battery::constraintsUpdated(Plasma::Constraints constraints)
+void Battery::constraintsEvent(Plasma::Constraints constraints)
{
if (constraints & Plasma::FormFactorConstraint) {
BackgroundHints background = NoBackground;
--- trunk/KDE/kdebase/workspace/plasma/applets/battery/battery.h #801662:801663
@@ -51,7 +51,7 @@
QSizeF contentSizeHint() const;
Qt::Orientations expandingDirections() const;
- void constraintsUpdated(Plasma::Constraints constraints);
+ void constraintsEvent(Plasma::Constraints constraints);
public slots:
void dataUpdated(const QString &name, const Plasma::DataEngine::Data &data);
--- trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp \
#801662:801663 @@ -185,7 +185,7 @@
delete m_timer;
}
-void DeviceNotifier::constraintsUpdated(Plasma::Constraints constraints)
+void DeviceNotifier::constraintsEvent(Plasma::Constraints constraints)
{
// on the panel we don't want a background, and our proxy widget in Planar has \
one setBackgroundHints(NoBackground);
--- trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h \
#801662:801663 @@ -76,7 +76,7 @@
void init();
void paintInterface(QPainter *p, const QStyleOptionGraphicsItem *option, \
const QRect &rect);
- void constraintsUpdated(Plasma::Constraints constraints);
+ void constraintsEvent(Plasma::Constraints constraints);
public slots:
void onSourceAdded(const QString &name);
void onSourceRemoved(const QString &name);
--- trunk/KDE/kdebase/workspace/plasma/applets/icon/icon.cpp #801662:801663
@@ -126,7 +126,7 @@
}
}
-void IconApplet::constraintsUpdated(Plasma::Constraints constraints)
+void IconApplet::constraintsEvent(Plasma::Constraints constraints)
{
setBackgroundHints(NoBackground);
@@ -220,7 +220,8 @@
if (m_url.isEmpty()) {
setUrl(urls.first());
- constraintsUpdated(Plasma::FormFactorConstraint);
+ //TODO: why we don't call updateConstraints()?
+ constraintsEvent(Plasma::FormFactorConstraint);
} else if (m_url.isLocalFile() &&
(m_mimetype &&
m_mimetype->is("application/x-executable") ||
--- trunk/KDE/kdebase/workspace/plasma/applets/icon/icon.h #801662:801663
@@ -44,7 +44,7 @@
void init();
void setUrl(const KUrl& url);
- void constraintsUpdated(Plasma::Constraints constraints);
+ void constraintsEvent(Plasma::Constraints constraints);
void showConfigurationInterface();
void setDisplayLines(int displayLines);
int displayLines();
--- trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp \
#801662:801663 @@ -105,7 +105,7 @@
d->icon->resize(geometry().size());
}
-void LauncherApplet::constraintsUpdated(Plasma::Constraints constraints)
+void LauncherApplet::constraintsEvent(Plasma::Constraints constraints)
{
setBackgroundHints(NoBackground);
if (constraints & Plasma::FormFactorConstraint) {
--- trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.h #801662:801663
@@ -46,7 +46,7 @@
void init();
- void constraintsUpdated(Plasma::Constraints constraints);
+ void constraintsEvent(Plasma::Constraints constraints);
virtual QList<QAction*> contextualActions();
--- trunk/KDE/kdebase/workspace/plasma/applets/lock_logout/lockout.cpp #801662:801663
@@ -87,7 +87,7 @@
}
}
-void LockOut::constraintsUpdated(Plasma::Constraints constraints)
+void LockOut::constraintsEvent(Plasma::Constraints constraints)
{
if (constraints & Plasma::FormFactorConstraint ||
constraints & Plasma::SizeConstraint) {
--- trunk/KDE/kdebase/workspace/plasma/applets/lock_logout/lockout.h #801662:801663
@@ -32,7 +32,7 @@
LockOut(QObject *parent, const QVariantList &args);
~LockOut();
void init();
- virtual void constraintsUpdated(Plasma::Constraints constraints);
+ virtual void constraintsEvent(Plasma::Constraints constraints);
public slots:
void clickLogout();
--- trunk/KDE/kdebase/workspace/plasma/applets/pager/pager.cpp #801662:801663
@@ -104,7 +104,7 @@
m_currentDesktop = KWindowSystem::currentDesktop();
}
-void Pager::constraintsUpdated(Plasma::Constraints constraints)
+void Pager::constraintsEvent(Plasma::Constraints constraints)
{
if (constraints & Plasma::SizeConstraint) {
recalculateGeometry();
--- trunk/KDE/kdebase/workspace/plasma/applets/pager/pager.h #801662:801663
@@ -41,7 +41,7 @@
void init();
void paintInterface(QPainter *painter, const QStyleOptionGraphicsItem \
*option, const QRect &contents);
- void constraintsUpdated(Plasma::Constraints);
+ void constraintsEvent(Plasma::Constraints);
virtual QList<QAction*> contextualActions();
public slots:
--- trunk/KDE/kdebase/workspace/plasma/applets/systemtray/systemtray.cpp \
#801662:801663 @@ -45,7 +45,7 @@
delete m_systemTrayWidget;
}
-void SystemTray::constraintsUpdated(Plasma::Constraints constraints)
+void SystemTray::constraintsEvent(Plasma::Constraints constraints)
{
if (constraints & Plasma::SizeConstraint) {
updateWidgetGeometry();
--- trunk/KDE/kdebase/workspace/plasma/applets/systemtray/systemtray.h #801662:801663
@@ -41,7 +41,7 @@
explicit SystemTray(QObject *parent, const QVariantList &arguments = \
QVariantList()); ~SystemTray();
- void constraintsUpdated(Plasma::Constraints constraints);
+ void constraintsEvent(Plasma::Constraints constraints);
private slots:
void updateWidgetGeometry();
--- trunk/KDE/kdebase/workspace/plasma/applets/tasks/tasks.cpp #801662:801663
@@ -174,7 +174,7 @@
m_windowTaskItems.clear();
}
-void Tasks::constraintsUpdated(Plasma::Constraints constraints)
+void Tasks::constraintsEvent(Plasma::Constraints constraints)
{
if (constraints & Plasma::LocationConstraint) {
if (formFactor() == Plasma::Vertical) {
--- trunk/KDE/kdebase/workspace/plasma/applets/tasks/tasks.h #801662:801663
@@ -65,7 +65,7 @@
void init();
- void constraintsUpdated(Plasma::Constraints constraints);
+ void constraintsEvent(Plasma::Constraints constraints);
void showConfigurationInterface();
protected slots:
--- trunk/KDE/kdebase/workspace/plasma/applets/trash/trash.cpp #801662:801663
@@ -131,7 +131,7 @@
m_icon->setPressed();
}
-void Trash::constraintsUpdated(Plasma::Constraints constraints)
+void Trash::constraintsEvent(Plasma::Constraints constraints)
{
setBackgroundHints(NoBackground);
--- trunk/KDE/kdebase/workspace/plasma/applets/trash/trash.h #801662:801663
@@ -48,7 +48,7 @@
~Trash();
void init();
- void constraintsUpdated(Plasma::Constraints constraints);
+ void constraintsEvent(Plasma::Constraints constraints);
public slots:
void slotOpen();
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic