[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/apps
From:       Albert Astals Cid <tsdgeos () terra ! es>
Date:       2008-04-24 20:41:05
Message-ID: 1209069665.541263.5815.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 800783 by aacid:

avoid unnecessary copies by using const & in foreach


 M  +4 -4      dolphin/src/dolphinview.cpp  
 M  +1 -1      dolphin/src/fileitemcapabilities.cpp  
 M  +6 -6      dolphin/src/iconmanager.cpp  
 M  +1 -1      dolphin/src/metadatawidget.cpp  
 M  +1 -1      dolphin/src/nepomukmassupdatejob.cpp  
 M  +1 -1      dolphin/src/tagcloud/resourcetaggingwidget.cpp  
 M  +1 -1      dolphin/src/tagcloud/tagcloud.cpp  
 M  +2 -2      kfind/kfindpart.cpp  
 M  +1 -1      kinfocenter/ioslaveinfo/kcmioslaveinfo.cpp  
 M  +2 -2      kinfocenter/moduletreeview.cpp  
 M  +1 -1      kinfocenter/partition/kcm_partition.cpp  
 M  +1 -1      konsole/src/Application.cpp  
 M  +1 -1      konsole/src/CopyInputDialog.cpp  
 M  +2 -2      konsole/src/ProcessInfo.cpp  
 M  +1 -1      konsole/src/ShellCommand.cpp  


--- trunk/KDE/kdebase/apps/dolphin/src/dolphinview.cpp #800782:800783
@@ -301,7 +301,7 @@
     KFileItemList itemList;
 
     const QModelIndexList indexList = selection.indexes();
-    foreach (QModelIndex index, indexList) {
+    foreach (const QModelIndex &index, indexList) {
         KFileItem item = m_dolphinModel->itemForIndex(index);
         if (!item.isNull()) {
             itemList.append(item);
@@ -315,7 +315,7 @@
 {
     KUrl::List urls;
     const KFileItemList list = selectedItems();
-    foreach (KFileItem item, list) {
+    foreach (const KFileItem &item, list) {
         urls.append(item.url());
     }
     return urls;
@@ -468,7 +468,7 @@
 
 void DolphinView::calculateItemCount(int& fileCount, int& folderCount)
 {
-    foreach (KFileItem item, m_dirLister->items()) {
+    foreach (const KFileItem &item, m_dirLister->items()) {
         if (item.isDir()) {
             ++folderCount;
         } else {
@@ -524,7 +524,7 @@
 
             // iterate through all selected items and rename them...
             int index = 1;
-            foreach (KFileItem item, items) {
+            foreach (const KFileItem &item, items) {
                 const KUrl& oldUrl = item.url();
                 QString number;
                 number.setNum(index++);
--- trunk/KDE/kdebase/apps/dolphin/src/fileitemcapabilities.cpp #800782:800783
@@ -32,7 +32,7 @@
     m_isLocal(true)
 {
     QFileInfo parentDirInfo;
-    foreach (KFileItem item, items) {
+    foreach (const KFileItem &item, items) {
         const KUrl url = item.url();
         m_isLocal = m_isLocal && url.isLocalFile();
         m_supportsReading  = m_supportsReading  && \
                KProtocolManager::supportsReading(url);
--- trunk/KDE/kdebase/apps/dolphin/src/iconmanager.cpp #800782:800783
@@ -107,7 +107,7 @@
     // Order the items in a way that the preview for the visible items
     // is generated first, as this improves the feeled performance a lot.
     KFileItemList orderedItems;
-    foreach (KFileItem item, items) {
+    foreach (const KFileItem &item, items) {
         const QModelIndex dirIndex = m_dolphinModel->indexForItem(item);
         const QModelIndex proxyIndex = m_proxyModel->mapFromSource(dirIndex);
         const QRect itemRect = m_view->visualRect(proxyIndex);
@@ -147,7 +147,7 @@
 {
     // restore the icons of all previously selected items to the
     // original state...
-    foreach (CutItem cutItem, m_cutItemsCache) {
+    foreach (const CutItem &cutItem, m_cutItemsCache) {
         const QModelIndex index = m_dolphinModel->indexForUrl(cutItem.url);
         if (index.isValid()) {
             m_dolphinModel->setData(index, QIcon(cutItem.pixmap), \
Qt::DecorationRole); @@ -207,7 +207,7 @@
     bool isOldPreview = true;
     const KUrl::List dirs = dirLister->directories();
     const QString itemDir = item.url().directory();
-    foreach (KUrl url, dirs) {
+    foreach (const KUrl &url, dirs) {
         if (url.path() == itemDir) {
             isOldPreview = false;
             break;
@@ -244,7 +244,7 @@
     const KUrl::List cutUrls = KUrl::List::fromMimeData(mimeData);
 
     const KUrl& itemUrl = item.url();
-    foreach (KUrl url, cutUrls) {
+    foreach (const KUrl &url, cutUrls) {
         if (url == itemUrl) {
             return true;
         }
@@ -263,11 +263,11 @@
     KFileItemList items;
     KDirLister* dirLister = m_dolphinModel->dirLister();
     const KUrl::List dirs = dirLister->directories();
-    foreach (KUrl url, dirs) {
+    foreach (const KUrl &url, dirs) {
         items << dirLister->itemsForDir(url);
     }
 
-    foreach (KFileItem item, items) {
+    foreach (const KFileItem &item, items) {
         if (isCutItem(item)) {
             const QModelIndex index = m_dolphinModel->indexForItem(item);
             const QVariant value = m_dolphinModel->data(index, Qt::DecorationRole);
--- trunk/KDE/kdebase/apps/dolphin/src/metadatawidget.cpp #800782:800783
@@ -123,7 +123,7 @@
     d->files.clear();
     bool first = true;
     QList<Nepomuk::Resource> fileRes;
-    Q_FOREACH( KUrl url, urls ) {
+    Q_FOREACH( const KUrl &url, urls ) {
         Nepomuk::Resource file( url, Soprano::Vocabulary::Xesam::File() );
         d->files.insert( url, file );
         fileRes.append( file );
--- trunk/KDE/kdebase/apps/dolphin/src/nepomukmassupdatejob.cpp #800782:800783
@@ -46,7 +46,7 @@
 void Nepomuk::MassUpdateJob::setFiles( const KUrl::List& urls )
 {
     m_resources.clear();
-    foreach( KUrl url, urls ) {
+    foreach( const KUrl &url, urls ) {
         m_resources.append( Resource( url ) );
     }
     setTotalAmount( KJob::Files, m_resources.count() );
--- trunk/KDE/kdebase/apps/dolphin/src/tagcloud/resourcetaggingwidget.cpp \
#800782:800783 @@ -57,7 +57,7 @@
 {
     popup->showAllTags();
     resourceTags = intersectTags( resources );
-    Q_FOREACH( Tag tag, resourceTags ) {
+    Q_FOREACH( const Tag &tag, resourceTags ) {
         popup->setTagSelected( tag, true );
     }
 
--- trunk/KDE/kdebase/apps/dolphin/src/tagcloud/tagcloud.cpp #800782:800783
@@ -651,7 +651,7 @@
     d->showAllTags = false;
     d->invalidateCachedValues();
     d->nodes.clear();
-    Q_FOREACH( Tag tag, tags ) {
+    Q_FOREACH( const Tag &tag, tags ) {
         TagNode node;
         node.tag = tag;
         node.weight = d->calculateWeight( tag );
--- trunk/KDE/kdebase/apps/kfind/kfindpart.cpp #800782:800783
@@ -126,7 +126,7 @@
 
   m_lstFileItems.removeAll( item );  //not working ?
 
-  foreach(const KFileItem iter, m_lstFileItems) {
+  foreach(const KFileItem &iter, m_lstFileItems) {
     if(iter.url() != item.url())
       listiter.append(iter);
   }
@@ -177,7 +177,7 @@
   m_kfindWidget->saveState( &stream );
   //Now we'll save the search result
   stream << m_lstFileItems.count();
-  foreach(const KFileItem fileitem, m_lstFileItems)
+  foreach(const KFileItem &fileitem, m_lstFileItems)
   {
         stream << fileitem;
   }
--- trunk/KDE/kdebase/apps/kinfocenter/ioslaveinfo/kcmioslaveinfo.cpp #800782:800783
@@ -78,7 +78,7 @@
 
 	QStringList protocols=KProtocolInfo::protocols();
 	protocols.sort();
-	foreach(QString proto, protocols) {
+	foreach(const QString &proto, protocols) {
 		//m_ioslavesLb->addItem(new QListWidgetItem ( SmallIcon( KProtocolInfo::icon( \
proto )), proto, m_ioslavesLb));  ioSlaves->addItem(SmallIcon( KProtocolInfo::icon( \
proto )), proto);  };
--- trunk/KDE/kdebase/apps/kinfocenter/moduletreeview.cpp #800782:800783
@@ -128,13 +128,13 @@
 	//kDebug() << "Module name " << moduleItem->module()->moduleName() << endl;
 	
 	QStringList keywords = moduleItem->module()->keywords();
-	foreach(QString keyword, keywords) {
+	foreach(const QString &keyword, keywords) {
 		//kDebug() << "Key word " << keyword << endl;
 		itemMatches.append(keyword);
 	}
 	
 	
-	foreach(QString itemMatch, itemMatches) {
+	foreach(const QString &itemMatch, itemMatches) {
 		if (itemMatch.contains(search, Qt::CaseInsensitive)) {
 			return true;
 		}
--- trunk/KDE/kdebase/apps/kinfocenter/partition/kcm_partition.cpp #800782:800783
@@ -171,7 +171,7 @@
 	tree->sortItems(0, Qt::AscendingOrder);
 	
 	//Do this later to be sure all UsedSizeWidget will be ready
-	foreach(QString accessPath, accessPaths) {
+	foreach(const QString &accessPath, accessPaths) {
 		connect(KDiskFreeSpace::findUsageInfo(accessPath), SIGNAL(foundMountPoint (const \
QString&, quint64, quint64, quint64)), this, SLOT(mountPointInfo(const QString&, \
quint64, quint64, quint64)) );  }
 
--- trunk/KDE/kdebase/apps/konsole/src/Application.cpp #800782:800783
@@ -218,7 +218,7 @@
     }
 
     // temporary changes to profile options specified on the command line
-    foreach( QString value , args->getOptionList("p") ) 
+    foreach( const QString &value , args->getOptionList("p") ) 
     {
         ProfileCommandParser parser;
         
--- trunk/KDE/kdebase/apps/konsole/src/CopyInputDialog.cpp #800782:800783
@@ -94,7 +94,7 @@
 
 	if (selected.count() > 1)
 	{
-		foreach(QModelIndex index,selected)
+		foreach(const QModelIndex &index,selected)
 			setRowChecked(index.row(),checked);
 	}
 	else 
--- trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp #800782:800783
@@ -399,7 +399,7 @@
 
         QStringList argList = data.split( QChar('\0') );
         
-        foreach ( QString entry , argList )
+        foreach ( const QString &entry , argList )
         {
             if (!entry.isEmpty())
                 addArgument(entry);
@@ -449,7 +449,7 @@
 
         QStringList bindingList = data.split( QChar('\0') );
    
-        foreach( QString entry , bindingList )
+        foreach( const QString &entry , bindingList )
         {
             QString name;
             QString value;
--- trunk/KDE/kdebase/apps/konsole/src/ShellCommand.cpp #800782:800783
@@ -93,7 +93,7 @@
 {
     QStringList result;
 
-    foreach( QString item , items )
+    foreach( const QString &item , items )
         result << expand(item);
 
     return result;


[prev in list] [next in list] [prev in thread] [next in thread]