[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/workspace/libs/plasma
From:       Anne-Marie Mahfouf <annma () kde ! org>
Date:       2008-04-24 13:09:22
Message-ID: 1209042562.466936.19674.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 800587 by annma:

API review: DataContainer SIGNAL requestUpdate()->updateRequested()
Not used anywhere outside libs/plasma, not used in /extragear/plasma or \
/playground/base/plasma Same case as SIGNAL unused()->becameUnused() as Kévin noted, \
can be moved to pimpl of DataContainer


 M  +1 -1      datacontainer.h  
 M  +1 -1      datacontainer_p.h  
 M  +1 -1      dataengine.cpp  


--- trunk/KDE/kdebase/workspace/libs/plasma/datacontainer.h #800586:800587
@@ -144,7 +144,7 @@
          * Emitted when the source, usually due to an internal timer firing,
          * requests to be updated.
          **/
-        void requestUpdate(DataContainer *source);
+        void updateRequested(DataContainer *source);
 
     private:
         friend class SignalRelay;
--- trunk/KDE/kdebase/workspace/libs/plasma/datacontainer_p.h #800586:800587
@@ -146,7 +146,7 @@
             checkAlignment();
         }
 
-        emit dc->requestUpdate(dc);
+        emit dc->updateRequested(dc);
         if (!dc->hasUpdates()) {
             // the source wasn't actually updated; so let's put ourselves in the \
queue  // so we get an dataUpdated() when the data does arrive
--- trunk/KDE/kdebase/workspace/libs/plasma/dataengine.cpp #800586:800587
@@ -116,7 +116,7 @@
             DataContainer* s = new DataContainer(engine);
             s->setObjectName(sourceName);
             sources.insert(sourceName, s);
-            connect(s, SIGNAL(requestUpdate(DataContainer*)), engine, \
SLOT(internalUpdateSource(DataContainer*))); +            connect(s, \
SIGNAL(updateRequested(DataContainer*)), engine, \
SLOT(internalUpdateSource(DataContainer*)));  
             if (limit > 0) {
                 trimQueue();


[prev in list] [next in list] [prev in thread] [next in thread]