[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kde3support/kdecore
From:       Luboš Luňák <l.lunak () kde ! org>
Date:       2008-04-23 9:02:08
Message-ID: 1208941328.807750.30156.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 800079 by lunakl:

Do not paranoidly sync every time, it causes I/O performance problems
for some users. People who still want it for whatever reason like using XFS
can set $KDE_EXTRA_FSYNC to 1.
(http://lists.kde.org/?l=kde-devel&m=120880682813170&w=2)



 M  +7 -4      k3tempfile.cpp  


--- trunk/KDE/kdelibs/kde3support/kdecore/k3tempfile.cpp #800078:800079
@@ -261,11 +261,14 @@
 
    if (mFd >= 0)
    {
-      result = FDATASYNC(mFd);
-      if (result)
+      if( qstrcmp( getenv( "KDE_EXTRA_FSYNC" ), "1" ) == 0 )
       {
-         kWarning() << "K3TempFile: Error trying to sync " << mTmpName << ": " << strerror(errno);
-         mError = errno;
+         result = FDATASYNC(mFd);
+         if (result)
+         {
+            kWarning() << "K3TempFile: Error trying to sync " << mTmpName << ": " << strerror(errno);
+            mError = errno;
+         }
       }
    }
 
[prev in list] [next in list] [prev in thread] [next in thread]