[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdevplatform/plugins/standardoutputview
From:       Andreas Pakulat <apaku () gmx ! de>
Date:       2008-04-20 22:14:51
Message-ID: 1208729691.987044.2815.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 799255 by apaku:

Fix always-scroll mode.


 M  +7 -28     outputwidget.cpp  
 M  +0 -2      outputwidget.h  


--- trunk/KDE/kdevplatform/plugins/standardoutputview/outputwidget.cpp #799254:799255
@@ -86,6 +86,11 @@
     if( data->outputdata.contains( id ) && data->outputdata.value(id)->view )
     {
         data->outputdata.value(id)->view->setModel(data->outputdata.value(id)->model);
 +        if( data->outputdata.value(id)->behaviour && \
KDevelop::IOutputView::AutoScroll ) +        {
+            connect( data->outputdata.value(id)->model, SIGNAL(rowsInserted(const \
QModelIndex&, int, int)), +                     data->outputdata.value(id)->view, \
SLOT(scrollToBottom()) ); +        }
     }
     else
     {
@@ -193,8 +198,6 @@
 {
     kDebug(9500) << "creating listview";
     QListView* listview = new QListView(this);
-    listview->setModel( data->outputdata.value(id)->model );
-    listview->setItemDelegate(data->outputdata.value(id)->delegate);
     listview->setEditTriggers( QAbstractItemView::NoEditTriggers );
     data->outputdata.value(id)->view = listview;
     connect( listview, SIGNAL(activated(const QModelIndex&)),
@@ -202,36 +205,12 @@
     connect( listview, SIGNAL(clicked(const QModelIndex&)),
              this, SLOT(activate(const QModelIndex&)));
 
-//     m_sliders[listview->verticalScrollBar()] = (m_outputView->behaviour(id) & \
                KDevelop::IOutputView::AutoScroll) ? 1 : 2;
-//     connect( listview->verticalScrollBar(), SIGNAL(rangeChanged(int, int)), this, \
                SLOT(rangeChanged(int, int)));
-//     connect( listview->verticalScrollBar(), SIGNAL(valueChanged(int)), this, \
                SLOT(valueChanged(int)));
-
     addTab( listview, data->outputdata.value(id)->title );
+    changeModel( id );
+    changeDelegate( id );
     return listview;
 }
-/*
-void OutputWidget::valueChanged(int value)
-{
-    QScrollBar* slider = qobject_cast<QScrollBar*>(sender());
-    Q_ASSERT(slider);
 
-    // TODO remove value once output view closed, but not a mem usage so low \
                priority
-    int atEnd = slider->maximum() == value ? 1 : 0;
-    if (m_sliders[slider] != 2)
-        m_sliders[slider] = atEnd;
-}
-
-void OutputWidget::rangeChanged(int min, int max)
-{
-    Q_UNUSED(min)
-
-    QScrollBar* slider = qobject_cast<QScrollBar*>(sender());
-    Q_ASSERT(slider);
-
-    if (m_sliders[slider] == 1)
-        slider->setValue(max);
-}*/
-
 void OutputWidget::raiseOutput(int id)
 {
     int idx = indexOf( data->outputdata.value(id)->view );
--- trunk/KDE/kdevplatform/plugins/standardoutputview/outputwidget.h #799254:799255
@@ -49,8 +49,6 @@
         void selectNextItem();
         void selectPrevItem();
         void activate(const QModelIndex&);
-//         void rangeChanged(int min, int max);
-//         void valueChanged(int value);
 
     Q_SIGNALS:
         void outputRemoved( int, int );


[prev in list] [next in list] [prev in thread] [next in thread]