[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/workspace/libs/plasma
From:       André_Wöbbeking <Woebbeking () kde ! org>
Date:       2008-04-11 14:54:18
Message-ID: 200804111654.19584.Woebbeking () kde ! org
[Download RAW message or body]

On Friday 11 April 2008, Rob Scheepmaker wrote:
> SVN commit 795821 by scheepmaker:
>
> Added the isAnimating() function to Phase. This way, applet/widgets
> can delay 'heavy' operations until all animations are finished to
> avoid stuttering animations.
>
>
>
>  M  +9 -0      phase.cpp
>  M  +2 -0      phase.h
>
>
> --- trunk/KDE/kdebase/workspace/libs/plasma/phase.cpp #795820:795821
> @@ -489,6 +489,15 @@
>      return state->pixmap;
>  }
>
> +//returns true if there are animations happening.
> +bool Phase::isAnimating()
> +{
> +    return (d->animatedItems.size() > 0 ||
> +            d->movingItems.size() > 0 ||
> +            d->animatedItems.size() > 0 ||
> +            d->customAnims.size() > 0);
> +}

1) const
2) !isEmpty() instead of size() > 0
3) no docs?
4) no @since?
[prev in list] [next in list] [prev in thread] [next in thread]