[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdereview/phonon/gstreamer
From:       Jens Bache-Wiig <jbache () trolltech ! com>
Date:       2008-04-10 12:37:15
Message-ID: 1207831035.628687.12443.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 795478 by jbache:

* Fixed a possible ycrash when changing audio device.



 M  +4 -3      audiooutput.cpp  


--- trunk/kdereview/phonon/gstreamer/audiooutput.cpp #795477:795478
@@ -153,11 +153,12 @@
             GstHelper::setProperty(m_audioSink, "device", oldDeviceValue);
             gst_element_set_state(m_audioSink, oldState);
         }
-
         // Note the stopped state should not really be neccessary, but seems to be \
required to   // properly reset after changing the audio state
-        QMetaObject::invokeMethod(root(), "setState", Qt::QueuedConnection, \
                Q_ARG(State, StoppedState));
-        root()->resumeState();
+        if (root()) {
+            QMetaObject::invokeMethod(root(), "setState", Qt::QueuedConnection, \
Q_ARG(State, StoppedState)); +            root()->resumeState();
+        }
     }
     return success;
 }


[prev in list] [next in list] [prev in thread] [next in thread]