[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    RE: KDE/kdelibs/phonon
From:       "Thierry Bastian" <thierry.bastian () trolltech ! com>
Date:       2008-03-11 13:25:01
Message-ID: 015401c8837b$4f4531d0$edcf9570$ () bastian () trolltech ! com
[Download RAW message or body]

In this specific case, performance is not an issue. It is only called when loading \
something which is not a file. I will still submit a change that does the parsing \
once.

Thierry

-----Original Message-----
From: David Faure [mailto:faure@kde.org] 
Sent: mardi 11 mars 2008 14:20
To: kde-commits@kde.org
Cc: Thierry Bastian
Subject: Re: KDE/kdelibs/phonon

On Tuesday 11 March 2008, Thierry Bastian wrote:
> +  } else if (QUrl(filename).isValid()) {
> d->url = filename;

This does the QUrl parsing twice though; if performance matters, checking isValid on \
d->url would be faster.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).


[prev in list] [next in list] [prev in thread] [next in thread]