[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/kdepim/enterprise/kdepim/kmail
From:       David Faure <dfaure () kdab ! net>
Date:       2008-03-07 11:35:35
Message-ID: 200803071235.36366.dfaure () kdab ! net
[Download RAW message or body]

On Friday 07 March 2008, Andreas Hartmetz wrote:
> Am Donnerstag 06 März 2008 18:32:00 schrieb Volker Krause:
> > SVN commit 782964 by vkrause:
> >
> > Fix corruption of binary attachments introduced in revision 771698.
> >
> > The actual problem here is that EncodingDetector::decode(_const_ QByteArray
> > &data) replaces all 0x00 bytes in data with 0x20 although being const.
> >
> Crazy, just crazy. Thanks for fixing it.

Well, that's the joy of explicit sharing in qt3 indeed.

But the right fix is to detach inside the decode() method, not to fix the caller...

-- 
David Faure, faure@kde.org, dfaure@klaralvdalens-datakonsult.se
KDE/KOffice developer, Qt consultancy projects
Klarälvdalens Datakonsult AB, Platform-independent software solutions

[prev in list] [next in list] [prev in thread] [next in thread]