[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepimlibs/gpgme++
From:       Marc Mutz <marc () kdab ! net>
Date:       2008-02-28 14:43:09
Message-ID: 200802281543.10483.marc () kdab ! net
[Download RAW message or body]

On Thursday February 28 2008 13:21, Adriaan de Groot wrote:
> SVN commit 780219 by adridg:
>
> strcmp isn't necessarily exported from namespace std (although gcc does
> this using already).
>
>  M  +2 -0      gpgsetexpirytimeeditinteractor.cpp
>  M  +2 -0      gpgsetownertrusteditinteractor.cpp
>
>
> --- trunk/KDE/kdepimlibs/gpgme++/gpgsetexpirytimeeditinteractor.cpp
> #780218:780219 @@ -27,6 +27,8 @@
>
>  #include <cstring>
>
> +using std::strcmp;

This will break on compilers that don't have their strcmp in std::, even 
though one includes <cstring>. Older gcc had this problem. Do we still care 
about those?

>  // avoid conflict (msvc)
>  #ifdef ERROR
>  # undef ERROR
> --- trunk/KDE/kdepimlibs/gpgme++/gpgsetownertrusteditinteractor.cpp
> #780218:780219 @@ -27,6 +27,8 @@
>
>  #include <cstring>
>
> +using std::strcmp;
> +
>  // avoid conflict (msvc)
>  #ifdef ERROR
>  # undef ERROR

-- 
Marc Mutz - marc@kdab.com, mutz@kde.org - Klarälvdalens Datakonsult AB
Platform-independent software solutions - www.kdab.com info@kdab.com

[prev in list] [next in list] [prev in thread] [next in thread]