[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdepim
From:       Pradeepto Bhattacharya <pradeepto () kde ! org>
Date:       2008-02-28 7:15:50
Message-ID: 1204182950.716134.3148.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 780166 by pradeepto:

Merged revisions 779694 via svnmerge from 
svn+ssh://pradeepto@svn.kde.org/home/kde/branches/kdepim/enterprise/kdepim

........
  r779694 | ahartmetz | 2008-02-27 01:37:15 +0530 (Wed, 27 Feb 2008) | 1 line
  
  Don't crash in TCPSlaveBase if the connection is already closed and thus the file \
descriptor is invalid/null. This seems to be what has been reported in Intevation \
                issue 2442.
........


 _M            . (directory)  
 M  +5 -2      kioslaves/sieve/sieve.cpp  


** branches/KDE/3.5/kdepim #property svnmerge-integrated
   - /branches/kdepim/enterprise/kdepim:1-767022,767033,767233-767554,767556,767558-76 \
7946,767948-769318,769320-769354,769356-771105,771107-771251,771253-772311,772313-7723 \
16,772318-775194,775196-775202,775204,775207-775211,775213-778001,778003-778004,778007 \
,778010-778011,778013-778029,778031-778727,778729-779448,779450-779482,779484-779505,779507-779693,779695-779852,779854-779994
  + /branches/kdepim/enterprise/kdepim:1-767022,767033,767233-767554,767556,767558-767 \
946,767948-769318,769320-769354,769356-771105,771107-771251,771253-772311,772313-77231 \
6,772318-775194,775196-775202,775204,775207-775211,775213-778001,778003-778004,778007, \
778010-778011,778013-778029,778031-778727,778729-779448,779450-779482,779484-779505,779507-779852,779854-779994
                
--- branches/KDE/3.5/kdepim/kioslaves/sieve/sieve.cpp #780165:780166
@@ -393,8 +393,11 @@
 	if (!forcibly) {
 		sendData("LOGOUT");
 
-		if (!operationSuccessful())
-			ksDebug() << "Server did not logout cleanly." << endl;
+		// This crashes under certain conditions as described in 
+		// http://intevation.de/roundup/kolab/issue2442
+		// Fixing KIO::TCPSlaveBase::atEnd() for !fd would also work but 3.x is on life \
support. +		//if (!operationSuccessful())
+		//	ksDebug() << "Server did not logout cleanly." << endl;
 	}
 
 	closeDescriptor();


[prev in list] [next in list] [prev in thread] [next in thread]