[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/workspace/systemsettings
From:       Michael Jansen <kde () michael-jansen ! biz>
Date:       2008-02-25 4:28:50
Message-ID: 1203913730.664827.1700.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 778974 by mjansen:

A bigger one

- Removed all traces of Ok|Cancel Buttons. Those where never shown anyway.
- Removed the close button. For all apply/revert modules the only way to leave
  is the showOverview Action top/left. No need to break that for non
  apply/revert modules (If there are any)
- Changed the apply/revert popup dialog to apply/revert/cancel
- Removed KCMultiWidget::m_ophanedModules. It was never filled anyway.
- Some general cleanup/structural changes.
- Don't use KMainWindow::closeEvent, queryClose() is needed.
- KCMultiWidget::apply tried to work on all submodules. default/revert only on
  the active. Fixed that. Now apply/revert/default only affect the visibile module.

One problem encountered: KPageDialog::currentPageChanged() is unstoppable :-).
When resetting the currentPage in that signal handler selected and actual
page get out of sync. And there is no such queryClose thing. 

BUG: 157840


 M  +106 -116  kcmultiwidget.cpp  
 M  +18 -33    kcmultiwidget.h  
 M  +20 -17    mainwindow.cpp  
 M  +7 -6      mainwindow.h  


[prev in list] [next in list] [prev in thread] [next in thread]