[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdepimlibs/kblog
From:       Mike Arthur <mike () mikearthur ! co ! uk>
Date:       2008-02-21 22:09:01
Message-ID: 1203631741.157736.7972.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 777912 by mikearthur:

Use sensible defaults for required fields.


 M  +5 -9      blogger1.cpp  
 M  +4 -0      metaweblog.cpp  
 M  +4 -0      movabletype.cpp  
 M  +4 -0      wordpressbuggy.cpp  


--- trunk/KDE/kdepimlibs/kblog/blogger1.cpp #777911:777912
@@ -207,6 +207,10 @@
   if( !id.isEmpty() ) {
     args << QVariant( id );
   }
+  else {
+    //Blog ID is a required parameter, guess at a default value
+    args << QVariant( "0" );
+  }
   args << QVariant( q->username() )
        << QVariant( q->password() );
   return args;
@@ -215,15 +219,7 @@
 // reimplemenet defaultArgs, since we may not use it virtually everywhere
 QList<QVariant> Blogger1Private::blogger1Args( const QString &id )
 {
-  Q_Q( Blogger1 );
-  QList<QVariant> args;
-  args << QVariant( QString( "0123456789ABCDEF" ) );
-  if( !id.isEmpty() ) {
-    args << QVariant( id );
-  }
-  args << QVariant( q->username() )
-       << QVariant( q->password() );
-  return args;
+  defaultArgs( id );
 }
 
 void Blogger1Private::slotFetchUserInfo( const QList<QVariant> &result, const QVariant &id )
--- trunk/KDE/kdepimlibs/kblog/metaweblog.cpp #777911:777912
@@ -109,6 +109,10 @@
   if( !id.isEmpty() ) {
     args << QVariant( id );
   }
+  else {
+    //Blog ID is a required parameter, guess at a default value
+    args << QVariant( "0" );
+  }
   args << QVariant( q->username() )
        << QVariant( q->password() );
   return args;
--- trunk/KDE/kdepimlibs/kblog/movabletype.cpp #777911:777912
@@ -102,6 +102,10 @@
   if( !id.isEmpty() ) {
     args << QVariant( id );
   }
+  else {
+    //Blog ID is a required parameter, guess at a default value
+    args << QVariant( "0" );
+  }
   args << QVariant( q->username() )
        << QVariant( q->password() );
   return args;
--- trunk/KDE/kdepimlibs/kblog/wordpressbuggy.cpp #777911:777912
@@ -260,6 +260,10 @@
   if ( !id.isEmpty() ) {
     args << QVariant( id );
   }
+  else {
+    //Blog ID is a required parameter, guess at a default value
+    args << QVariant( "0" );
+  }
   args << QVariant( q->username() )
        << QVariant( q->password() );
   return args;
[prev in list] [next in list] [prev in thread] [next in thread]