[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepim/plugins/kmail/bodypartformatter
From:       Till Adam <till () kdab ! net>
Date:       2008-02-17 12:21:58
Message-ID: DB0E4E8C-1EEE-4F66-B7DF-E4B97703683E () kdab ! net
[Download RAW message or body]


On Feb 17, 2008, at 12:44 AM, Ingo Klöcker wrote:

> On Saturday 16 February 2008, Till Adam wrote:
>> +      const QString addedLineStyle( "style=\"" "color: green;\"" );
>
> Why is this a QString while everything else is a QLatin1String?
>
> And wouldn't it make sense to make those static const so that they are
> constructed only once? I guess it doesn't really matter because the
> c'tor of QLatin1String is dead-cheap, but it might serve as example  
> for
> other usages of constants.

Indeed, I've done both.

Thanks,

Till
[prev in list] [next in list] [prev in thread] [next in thread]