[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepim/kalarm
From:       David Faure <dfaure () kdab ! net>
Date:       2008-02-12 22:44:16
Message-ID: 200802122344.17105.dfaure () kdab ! net
[Download RAW message or body]

On Tuesday 12 February 2008, David Jarvie wrote:
> On Tue 12 February 2008 14:16:59 Jaroslaw Staniek wrote:
> > SVN commit 774111 by staniek:
> >
> > no need for QFile::encodeName() in QFile ctor
> >
> >
> >  M  +1 -1      kalarmapp.cpp
> >
> >
> > --- trunk/KDE/kdepim/kalarm/kalarmapp.cpp #774110:774111
> > @@ -1752,7 +1752,7 @@
> >  		}
> >  		else
> >  			heading = QLatin1String("\n******* KAlarm *******\n");
> > -		QFile logfile(QFile::encodeName(event.logFile()));
> > +		QFile logfile(event.logFile());
> >  		if (logfile.open(QIODevice::Append | QIODevice::Text))
> >  		{
> >  			QTextStream out(&logfile);
> 
> Could you please explain why QFile::encodeName() should be removed? I'm never 
> too sure when encoding is necessary and when it isn't.

Easy: the QFile constructor takes a QString, so simply passing it a QString is correct.

QFile::encodeName gives a QByteArray (8 bit char data), so it's for methods that take a QByteArray
or a const char* (like ::fopen or ::opendir etc.).

-- 
David Faure, faure@kde.org, dfaure@klaralvdalens-datakonsult.se
KDE/KOffice developer, Qt consultancy projects
Klarälvdalens Datakonsult AB, Platform-independent software solutions

[prev in list] [next in list] [prev in thread] [next in thread]