[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepim/akonadi/libakonadi
From:       Kevin Krammer <kevin.krammer () gmx ! at>
Date:       2008-02-09 16:15:35
Message-ID: 200802091715.36035.kevin.krammer () gmx ! at
[Download RAW message or body]


On Saturday 09 February 2008, Volker Krause wrote:
> On Friday 08 February 2008 22:14:50 Kevin Krammer wrote:
> > SVN commit 772470 by krake:
> >
> > Make ItemSync available as public API:
> > - change id -> item mapping from usage of remoteId() to id() so clients
> > can use ItemSync to create new items in Akonadi without having to fake a
> > remoteId - install the header
>
> This seems to break resources. There, items don't have ids yet when they
> are delivered from the resource and thus need to be compared by their
> remoteids to see if they already exist in Akonadi. Without that I get a new
> set of duplicated items per sync. So, we probably need both modes, either
> available as an option in the API, or (if that's possible) by autodetecting
> if items need to be compared by id or remoteid.

You mean around line 117?

Maybe first try a lookup based in the local ID and if this fails based on the 
remote ID?

> > - remove the API dox declaring it as internal, also remove the comment
> > about transactions since it is back to being a transaction.
> >
> > @Volker: "local" and "remote" should probably be renamed
>
> Right, that has the inverse meaning in your use-case.

Yes, not that important though.

Cheers,
Kevin
-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]