[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepim/kmail (silent)
From:       Till Adam <till () kdab ! net>
Date:       2008-02-08 17:41:31
Message-ID: 200802081841.33326.till () kdab ! net
[Download RAW message or body]

On Friday 08 February 2008 18:04:37 Thomas McGuire wrote:
> On Friday 08 February 2008, Till Adam wrote:
> > > SVN commit 772385 by tmcguire:
> > >
> > > Remove unused, commented out stuff.
> > >
> > > Part of a patch by Mischael Schill <me at mschill dot ch>
> >
> > readTemporaryMsg is very much needed. If there's a problem with it, we
> > need to fix it, but please don't just remove it. It took David Faure
> > considerable time to track down these cases, let's not undo that work
> > blindly.
> >
> > Thomas, I strongly suggest to revert that part of the patch and discuss
> > the reason for that method and possible problems with it in a lot more
> > detail on the list. This is very fragile code, changes to this layer of
> > KMail should be very thoroughly reviewed.
>
> That's what I wanted to do, I commited this by accident, I only wanted to
> commit the removal of the commented out code. My plan was to try to
> reproduce the problem myself and find the real cause.

What I'm saying is that that method should not be removed, not even commented 
out, it is there for a reason. If it has problems, those need to be fixed.

Till


-- 
Till Adam
KDAB - platform independent software services
[prev in list] [next in list] [prev in thread] [next in thread]