[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    extragear/plasma/dataengines/twitter
From:       Chani Armitage <chanika () gmail ! com>
Date:       2008-02-05 14:53:40
Message-ID: 1202223220.977966.31368.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 771236 by chani:

don't create obviously bogus sources


 M  +9 -1      twitterengine.cpp  


--- trunk/extragear/plasma/dataengines/twitter/twitterengine.cpp #771235:771236
@@ -94,9 +94,13 @@
 bool TwitterEngine::sourceRequested(const QString &name)
 {
     kDebug() << name;
+    if (name != "UserImages" && name != "LatestImage" && ! name.startsWith("Error")
+            && ! name.startsWith("Timeline")) {
+        return false;
+    }
     setData(name, DataEngine::Data()); //need to have something because we're async.
     updateSource(name); //start a download
-    return true; //TODO what if they requested a nonsense source like "foobar"?
+    return true;
 }
 
 //everything but image?
@@ -225,6 +229,10 @@
 bool TwitterEngine::updateSource(const QString &source)
 {
     kDebug() << source;
+    //right now it only makes sense to do an update on timelines
+    if (! source.startsWith("Timeline")) {
+        return false;
+    }
     if (source=="Timeline") {
         updateTimeline();
     }
[prev in list] [next in list] [prev in thread] [next in thread]