[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/runtime/khelpcenter
From:       David Faure <faure () kde ! org>
Date:       2008-01-28 13:04:56
Message-ID: 200801281404.56743.faure () kde ! org
[Download RAW message or body]

On Sunday 27 January 2008, Oswald Buddenhagen wrote:
> On Sun, Jan 27, 2008 at 03:41:12PM +0000, Ralf Habacker wrote:
> > --- trunk/KDE/kdebase/runtime/khelpcenter/searchengine.cpp #767223:767224
> > +void SearchEngine::searchExited(int exitCode, QProcess::ExitStatus exitStatus)
> >  {
> >    kDebug() << "Search terminated";
> >    mSearchRunning = false;
> >  }
> > @@ -339,36 +316,32 @@
> > +    mProc->start();
> > +    if (!mProc->waitForStarted()) {
> > +    }
> > +    
> > +    while (mSearchRunning && mProc->state() == QProcess::Running)
> >        kapp->processEvents();
> >  
> i know that's not your idea, but it is a pretty terrible one, so you
> might want to refactor this code.

Looks like this is exactly what waitForFinished does now, isn't it?

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]