[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    playground/libs/kgllib/core/kgllib
From:       Rivo Laks <rivolaks () hot ! ee>
Date:       2008-01-25 12:34:12
Message-ID: 1201264452.422834.1770.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 766201 by rivol:

Autobind was a bad idea after all

 M  +0 -6      renderer.cpp  
 M  +0 -9      renderer.h  


--- trunk/playground/libs/kgllib/core/kgllib/renderer.cpp #766200:766201
@@ -28,7 +28,6 @@
 
 Renderer::Renderer()
 {
-    mAutoBind = false;
     mDefaultTextureFilter = GL_LINEAR_MIPMAP_LINEAR;
     mDefaultTextureWrapMode = GL_CLAMP;
     mAutoDebugOutput = false;
@@ -77,11 +76,6 @@
     }
 }
 
-void Renderer::setAutoBind(bool bind)
-{
-    mAutoBind = bind;
-}
-
 void Renderer::setDefaultTextureFilter(GLenum filter)
 {
     mDefaultTextureFilter = filter;
--- trunk/playground/libs/kgllib/core/kgllib/renderer.h #766200:766201
@@ -40,25 +40,16 @@
 
     virtual bool bindProgram(const Program* prog);
 
-    // TODO: maybe have setAutoBind()/autoBind() methods? If autoBind() is
-    //  true then every texture/shader/etc operation would cause the
-    //  corresponding object to be bind()ed automatically. Is this a good idea
-    //  (as it would make things easier for app devels) or a bad one (as it
-    //  would cause devels not to understand what's actually going on)?
-
     // The highly experimental API follows:
-    void setAutoBind(bool bind);
     void setDefaultTextureFilter(GLenum filter);
     void setDefaultTextureWrapMode(GLenum mode);
     void setAutoDebugOutput(bool output);
 
-    bool autoBind() const  { return mAutoBind; }
     GLenum defaultTextureFilter() const  { return mDefaultTextureFilter; }
     GLenum defaultTextureWrapMode() const  { return mDefaultTextureWrapMode; }
     bool autoDebugOutput() const  { return mAutoDebugOutput; }
 
 private:
-    bool mAutoBind;
     GLenum mDefaultTextureFilter;
     GLenum mDefaultTextureWrapMode;
     bool mAutoDebugOutput;
[prev in list] [next in list] [prev in thread] [next in thread]