[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/runtime/drkonqi
From:       Urs Wolfer <uwolfer () kde ! org>
Date:       2008-01-23 19:18:31
Message-ID: 1201115911.610404.17713.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 765285 by uwolfer:

Change a few things (thanks to aseigo's ideas):
* Require less space on screens; reduce redundant information
* Rewording of some texts
* Fix typo on stylesheet
Benjamin: I have changed the calculation of the dialog width because there is now \
less text; I hope you agree on that change.

CCMAIL:aseigo@kde.org,benjamin.stuhl@colorado.edu

 M  +6 -0      debugger.cpp  
 M  +1 -0      debugger.h  
 M  +1 -1      presets/enduserrc  
 M  +4 -8      toplevel.cpp  


--- trunk/KDE/kdebase/runtime/drkonqi/debugger.cpp #765284:765285
@@ -234,3 +234,9 @@
   }
   return ret;
 }
+
+QSize KrashDebugger::sizeHint() const
+{
+    // reduce inital size a bit (the text browser is affected)
+    return QSize(QWidget::sizeHint().width(), QWidget::sizeHint().height() / 3 * 2);
+}
--- trunk/KDE/kdebase/runtime/drkonqi/debugger.h #765284:765285
@@ -54,6 +54,7 @@
   bool performChecks( QString* msg );
 
   virtual void showEvent(QShowEvent *e);
+  virtual QSize sizeHint() const;
 
 protected Q_SLOTS:
   void slotCopy();
--- trunk/KDE/kdebase/runtime/drkonqi/presets/enduserrc #765284:765285
@@ -95,7 +95,7 @@
 
 [WhatToDoHint]
 Enable=true
-Name=Please help us improving this application by reporting this error at <a \
href="http://bugs.kde.org">http://bugs.kde.org</a>. Please include as much \
information as possible, maybe the original documents. If you have a way to reproduce \
the error, include this also. +Name=Please help us improve the software you use by \
filling a report at <a href="http://bugs.kde.org">http://bugs.kde.org</a>. Useful \
details include how to reporduce the error, documents that were loaded, etc.  \
Name[el]=Βοηθήστε μας να βελτιώσουμε την εφαρμογή αυτή αναφέροντας αυτό το σφάλμα στο \
<a href="http://bugs.kde.org">http://bugs.kde.org</a>. Παρακαλώ συμπεριλάβετε όσες \
περισσότερες πληροφορίες είναι δυνατό και ίσως ακόμη και τα αρχικά έγγραφα. Αν \
γνωρίζετε κάποιο τρόπο για την αναπαραγωγή του σφάλματος, συμπεριλάβετε και αυτόν.  \
Name[ga]=Cabhraigh linn trí thuairisc a sheoladh chuig <a \
href="http://bugs.kde.org">http://bugs.kde.org/</a> maidir leis an earráid seo. Déan \
do dhícheall an méid is mó is feidir eolais a chur san áireamh, na buncháipéisi mar \
shampla.  Más féidir leat an earráid a atáirgeadh, cuir é seo san áireamh freisin.  \
Name[km]=អ្នក​ប្រហែល​ចង់​ផ្ញើ​របាយការណ៍​កំហុស​សម្រាប់​កម្មវិធី​នេះ ។ ពិនិត្យ​មើល​ថាតើ \
វា​មាន​រាយ​នៅ​ក្នុង http://bugs.kde.org ឬ​អត់ បើ​មិនឃើញ​មានទេ \
សូម​ផ្ញើ​សំបុត្រ​ទៅ​អ្នក​និពន្ធ ។ \
សូម​រួមបញ្ចូល​ព័ត៌មាន​ឲ្យ​បាន​ច្រើន​តាម​ដែល​អាច​ធ្វើ​ទៅ​បាន អាច​ជាឯកសារ​ដើម ។ \
                ប្រសិន​បើ​អ្នក​មាន​វិធី​ដើម្បី​ធ្វើ​ឲ្យ​មាន​កំហុស​ឡើងវិញ​នោះ \
                សូម​រួមបញ្ចូល​វា​ផងដែរ ។
--- trunk/KDE/kdebase/runtime/drkonqi/toplevel.cpp #765284:765285
@@ -66,10 +66,9 @@
   info->setOpenExternalLinks(true);
   info->setWordWrap(true);
 
-  // if possible, try to fit the error description all on one line
   // the +20 pixels is some slop for QLabel
   int suggestedWidth = !m_krashconf->errorDescriptionText().isEmpty() ?
-        info->fontMetrics().width(m_krashconf->errorDescriptionText()) + 2 * \
marginHint() + 20 +        \
(info->fontMetrics().width(m_krashconf->errorDescriptionText()) / 3 * 2) + (2 * \
marginHint() + 20)  : info->sizeHint().width() + 100;
   // ... but try to make sure the dialog fits on an 800x600 screen
   int width = qMin(suggestedWidth, 750);
@@ -78,7 +77,7 @@
   QString styleSheet = QString("QLabel {"
                        "padding: 10px;"
                        "background-image: url(%1);"
-                       "background-repeat: no-repleat;"
+                       "background-repeat: no-repeat;"
                        "background-position: right;"
                        "}").arg(KStandardDirs::locate("appdata", \
QLatin1String("pics/konqi.png")));  info->setStyleSheet(styleSheet);
@@ -91,9 +90,7 @@
   if (m_krashconf->showBacktrace())
   {
     m_detailDescriptionLabel = new QLabel(this);
-    m_detailDescriptionLabel->setText(QString("<p style=\"margin: 10px;\">%1<br \
                /><br />%2</p>")
-                                              .arg(m_krashconf->signalText())
-                                              .arg(i18n("Please attach the following \
backtrace to your bug report:"))); +    \
m_detailDescriptionLabel->setText(i18n("Please attach the following information to \
your bug report:"));  m_detailDescriptionLabel->setWordWrap(true);
     m_detailDescriptionLabel->setTextInteractionFlags(Qt::TextBrowserInteraction);
     m_detailDescriptionLabel->setAlignment(Qt::AlignJustify);
@@ -139,8 +136,7 @@
        m_krashconf->errorDescriptionText();
 
   if (!m_krashconf->whatToDoText().isEmpty())
-    str += QString("<p style=\"margin-top: 6px; margin-bottom: \
                6px;\"><b>%1</b></p>").arg(i18n("What can I do?")) +
-       m_krashconf->whatToDoText();
+    str += "<br />" + m_krashconf->whatToDoText();
 
   // check if the string is still empty. if so, display a default.
   if (str.isEmpty())


[prev in list] [next in list] [prev in thread] [next in thread]