[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdenetwork/knewsticker
From:       Frerich Raabe <raabe () kde ! org>
Date:       2008-01-23 0:51:21
Message-ID: 1201049481.981537.2815.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 765033 by raabe:

- Avoid crash when switching from paged view to scrolling view while the
  paged view is exchanging the item. We deleted the PagingItemView (which
  eventually deleted all the HyperlinkItem objects) but didn't stop the
  move in/out animations, so the timer accessed a dangling pointer.


 M  +6 -0      itemviews.cpp  
 M  +1 -0      itemviews.h  


--- trunk/KDE/kdenetwork/knewsticker/itemviews.cpp #765032:765033
@@ -286,6 +286,12 @@
     m_moveOutAnimation->setTimeLine( moveOutTimer );
 }
 
+PagingItemView::~PagingItemView()
+{
+    m_moveInAnimation->timeLine()->stop();
+    m_moveOutAnimation->timeLine()->stop();
+}
+
 void PagingItemView::updateMoveAnimations()
 {
     m_moveInAnimation->clear();
--- trunk/KDE/kdenetwork/knewsticker/itemviews.h #765032:765033
@@ -137,6 +137,7 @@
     Q_OBJECT
 public:
     PagingItemView( KNewsTicker *parent = 0 );
+    virtual ~PagingItemView();
 
     virtual void setItems( const QList<NewsItem> &items );
     virtual void reloadSettings();
[prev in list] [next in list] [prev in thread] [next in thread]