[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/4.0/kdelibs/khtml/xml
From:       Harri Porten <porten () kde ! org>
Date:       2008-01-13 20:56:04
Message-ID: 1200257764.150076.7416.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 760977 by porten:

I am not sure I can interpret this from the wording of the spec. But if
insertNode() of the Range interface should actually insert a node into
the range we'll have to extend it. Found in an Acid3 test that inserted
a node in collapsed range.


 M  +4 -0      dom2_rangeimpl.cpp  


--- branches/KDE/4.0/kdelibs/khtml/xml/dom2_rangeimpl.cpp #760976:760977
@@ -803,9 +803,13 @@
         if (exceptioncode)
             return;
         m_startContainer->parentNode()->insertBefore( newNode, newText, \
exceptioncode ); +	// ### adapt range?
     }
     else {
         m_startContainer->insertBefore( newNode, m_startContainer->childNode( \
m_startOffset ), exceptioncode ); +	if (exceptioncode)
+	    return;
+	++m_endOffset;
     }
 }
 


[prev in list] [next in list] [prev in thread] [next in thread]