[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/plugins/tableshape
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2008-01-12 13:01:08
Message-ID: 1200142868.355771.9951.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 760340 by rempt:

Update todo and design notes.


 M  +1 -1      DESIGN.txt  
 M  +4 -0      TODO  
 M  +0 -9      TableCell.cpp  
 M  +3 -1      TableCell.h  


--- trunk/koffice/plugins/tableshape/DESIGN.txt #760339:760340
@@ -27,5 +27,5 @@
 
 Query: should the tableshape be a shape or a shape container?
 
-
+Note: MS Word tables do have variable column widths per row -- see shaheed's remarks on IRC
 Note: table cells must be reversed in rtl languages!
--- trunk/koffice/plugins/tableshape/TODO #760339:760340
@@ -1,7 +1,11 @@
                   TODO file for the texttable shape
                   =================================
 
+Datamodel
 
+* should be able to fit all ODF text table data, except for formula's
+* does not need to be able to handle MS Word variable column width per row tables
+
 Proof-of-concept read-only table
  * Support small tables with a fixed number of rows and columns
     - Fixed size (table and cells)
--- trunk/koffice/plugins/tableshape/TableCell.cpp #760339:760340
@@ -55,15 +55,6 @@
     delete d;
 }
 
-TableCell::TableCell(const TableCell & rhs)
-    : QObject()
-    , QTextTableCell(rhs)
-    , d( new Private())
-    {
-        // XXX: Can we copy or clone a shape?
-        //d->shape = KoShape(rhs.d->shape);
-    }
-
 KoShape * TableCell::shape( ) const
 {
     return d->shape;
--- trunk/koffice/plugins/tableshape/TableCell.h #760339:760340
@@ -41,8 +41,8 @@
 
     ~TableCell();
 
-    TableCell(const TableCell & rhs);
 
+
     /**
      * @return the shape that contains the contents for this cell. May be 0
      * if no shape exists for this cell; the cell is empty in that case.
@@ -83,6 +83,8 @@
     class Private;
     Private * const d;
 
+    // Private, since we cannot clone shapes, we cannot copy-construct table cells
+    TableCell(const TableCell & rhs);
 };
 
 #endif
[prev in list] [next in list] [prev in thread] [next in thread]