[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/kexi/plugins/forms
From:       Sebastian Sauer <mail () dipe ! org>
Date:       2008-01-06 23:54:28
Message-ID: 1199663668.042850.18506.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 758134 by sebsauer:

and one more crash fix.

 M  +4 -2      kexidataprovider.cpp  


--- trunk/koffice/kexi/plugins/forms/kexidataprovider.cpp #758133:758134
@@ -273,10 +273,12 @@
 	//i = 0;
 	m_disableFillDuplicatedDataItems = true; // temporary disable fillDuplicatedDataItems()
 	                                         // because setColumnInfo() can activate it
-	KexiFormDataItemInterface *item;
 	for (QList<KexiFormDataItemInterface*>::iterator it( m_dataItems.begin() ); 
-		(item = *it);)
+        it != m_dataItems.end(); )
 	{
+        KexiFormDataItemInterface *item = *it;
+        Q_ASSERT(item);
+
 		if (invalidSources.contains( item->dataSource().toLower() )) {
 			item->setInvalidState( QString::fromLatin1("#%1?").arg(i18n("NAME")) );
 			it = m_dataItems.erase(it);
[prev in list] [next in list] [prev in thread] [next in thread]