[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/extragear/kde3/libs/kipi-plugins/batchprocessimages
From:       Gilles Caulier <caulier.gilles () gmail ! com>
Date:       2008-01-04 12:45:15
Message-ID: 1199450715.731646.26223.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 757195 by cgilles:

check if ImageMagick command line is exit normally when process is done, not just \
fater to startup it.

BUG: 151578


 M  +8 -8      batchprocessimagesdialog.cpp  


--- branches/extragear/kde3/libs/kipi-plugins/batchprocessimages/batchprocessimagesdialog.cpp \
#757194:757195 @@ -6,7 +6,7 @@
  * Date        : 2004-10-01
  * Description : a kipi plugin to batch process images
  *
- * Copyright (C) 2004-2007 by Gilles Caulier <caulier dot gilles at gmail dot com>
+ * Copyright (C) 2004-2008 by Gilles Caulier <caulier dot gilles at gmail dot com>
  *
  * This program is free software; you can redistribute it
  * and/or modify it under the terms of the GNU General
@@ -825,13 +825,6 @@
         m_previewButton->setEnabled(true);
         return;
     }
-
-    if (!m_PreviewProc->normalExit())
-    {
-        KMessageBox::error(this, i18n("Cannot run properly 'convert' program from \
                'ImageMagick' package."));
-        m_previewButton->setEnabled(true);
-        return;
-    }
 }
 
 void BatchProcessImagesDialog::slotPreviewReadStd(KProcess* /*proc*/, char *buffer, \
int buflen) @@ -841,6 +834,13 @@
 
 void BatchProcessImagesDialog::slotPreviewProcessDone(KProcess* proc)
 {
+    if (!m_PreviewProc->normalExit())
+    {
+        KMessageBox::error(this, i18n("Cannot run properly 'convert' program from \
'ImageMagick' package.")); +        m_previewButton->setEnabled(true);
+        return;
+    }
+
     BatchProcessImagesItem *item = static_cast<BatchProcessImagesItem*>( \
m_listFiles->currentItem() );  int ValRet = proc->exitStatus();
 


[prev in list] [next in list] [prev in thread] [next in thread]