[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/apps/nsplugins
From:       Johannes Simon <johannes.simon () gmail ! com>
Date:       2007-12-27 10:39:30
Message-ID: 1198751970.237167.31833.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 753395 by jsimon:

Fix in loadPlugins(): When the mimetype is parsed, there are not always additional \
suffixes. But they were expected which caused loadPlugins() to try to access a \
non-existing array element. This caused a crash everytime I accessed a web page with \
konqueror that contains flash elements.




 M  +4 -1      nspluginloader.cpp  


--- trunk/KDE/kdebase/apps/nsplugins/nspluginloader.cpp #753394:753395
@@ -205,7 +205,10 @@
 
       QStringList desc = line.split(':', QString::KeepEmptyParts);
       QString mime = desc[0].trimmed();
-      QStringList suffixes = desc[1].trimmed().split(',');
+      QStringList suffixes;
+      // If there are no suffixes, this would cause a crash
+      if (desc.count() > 1)
+        suffixes = desc[1].trimmed().split(',');
       if (!mime.isEmpty())
         {
           // insert the mimetype -> plugin mapping


[prev in list] [next in list] [prev in thread] [next in thread]