[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/filters/kspread/gnumeric
From:       Alfredo Beaumont Sainz <alfredo.beaumont () gmail ! com>
Date:       2007-12-02 14:56:56
Message-ID: 1196607416.776808.28874.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 744013 by abeaumont:

Fix cell merging. Merged cell region is calculated properly, but
CellStorage::mergeCells() increases both width and height. I don't get why and
seems counterintuitive to me, a comment with a short explanation would help.

CCMAIL: stefan.nikolaus@kdemail.net


 M  +1 -1      gnumericimport.cc  


--- trunk/koffice/filters/kspread/gnumeric/gnumericimport.cc #744012:744013
@@ -2220,7 +2220,7 @@
             //kDebug()<<"text !!! :"<<cell_merge_area<<"range :start row \
:"<<range.startRow ()<<" start col :"<<range.startCol ()<<" end row :"<<range.endRow \
                ()<<" end col :"<<range.endCol ();
             Cell cell = Cell( table, region.firstRange().left(), \
                region.firstRange().top() );
             cell.mergeCells( region.firstRange().left(), region.firstRange().top(),
-                             region.firstRange().width(), \
region.firstRange().height() ); +                             \
region.firstRange().width() - 1, region.firstRange().height() - 1);  mergedRegion = \
mergedRegion.nextSibling();  }
 	/* There is a memory leak here...


[prev in list] [next in list] [prev in thread] [next in thread]