[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdenetwork/kppp
From:       Kevin Krammer <kevin.krammer () gmx ! at>
Date:       2007-11-25 18:44:16
Message-ID: 1196016256.448710.4271.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 741483 by krake:

Fixing painting in "Details" dialog.

Used to be done by bitBlt from pixmaps to child widgets, but Qt4 does not allow
painting on widgets outside of paintEvent -> use QLabel::setPixmap() instead



 M  +3 -12     pppstatdlg.cpp  
 M  +1 -2      pppstatdlg.h  


--- trunk/KDE/kdenetwork/kppp/pppstatdlg.cpp #741482:741483
@@ -176,7 +176,7 @@
 
     gpppdata.graphingOptions(dummy, bg, text, in, out);
 
-    graph = new QFrame(this);
+    graph = new QLabel(this);
     graph->setFrameStyle(QFrame::Box | QFrame::Sunken);
     l1->addMultiCellWidget(graph, 2, 2, 1, 2);
     graph->setMinimumWidth(300);
@@ -308,7 +308,7 @@
   p.drawLine(0, 8, r.left() - 8, 8);
 
   p.end();
-  bitBlt(graph, 2, 2, &pm, 0, 0, pm.width(), pm.height());
+  graph->setPixmap(pm);
 }
 
 void PPPStatsDlg::updateGraph() {
@@ -326,16 +326,7 @@
   paintGraph();
 }
 
-
-void PPPStatsDlg::paintEvent (QPaintEvent *) {
-  paintIcon(PPPStats::BytesNone); // correct ?
-  if(gpppdata.graphingEnabled())
-    paintGraph();
-}
-
-
 void PPPStatsDlg::paintIcon(int status) {
-
   const QPixmap *pixmap;
 
   switch(status)
@@ -355,7 +346,7 @@
       break;
     }
 
-  bitBlt(pixmap_l, 0, 0, pixmap);
+  pixmap_l->setPixmap(*pixmap);
 
   update_data();
 }
--- trunk/KDE/kdenetwork/kppp/pppstatdlg.h #741482:741483
@@ -58,7 +58,6 @@
 protected:
 
   void closeEvent( QCloseEvent *e );
-  void paintEvent (QPaintEvent *e) ;
   bool event( QEvent *e );
 
 public slots:
@@ -120,7 +119,7 @@
   Q3GroupBox    *box;
 
   // graph widget
-  QFrame *graph;
+  QLabel *graph;
   int bin[MAX_GRAPH_WIDTH];
   int bout[MAX_GRAPH_WIDTH];
   int bin_last;
[prev in list] [next in list] [prev in thread] [next in thread]