[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdegraphics/kpdf/core/generator_pdf [POSSIBLY UNSAFE]
From:       Albert Astals Cid <tsdgeos () terra ! es>
Date:       2007-11-23 18:16:13
Message-ID: 1195841773.263821.13728.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 740624 by aacid:

sscanf crashes on a NULL pointer so verify s is not empty. Fixes bug 152710, well, \
                not really as the scanner uses poppler, i'll fix poppler in a minute
BUG: 152710


 M  +1 -1      generator_pdf.cpp   [POSSIBLY UNSAFE: scanf]


--- branches/KDE/3.5/kdegraphics/kpdf/core/generator_pdf/generator_pdf.cpp \
#740623:740624 @@ -808,7 +808,7 @@
         if ( s[0] == 'D' && s[1] == ':' )
             s = s.mid(2);
 
-        if ( sscanf( s.latin1(), "%4d%2d%2d%2d%2d%2d", &year, &mon, &day, &hour, \
&min, &sec ) == 6 ) +        if ( !s.isEmpty() && sscanf( s.latin1(), \
"%4d%2d%2d%2d%2d%2d", &year, &mon, &day, &hour, &min, &sec ) == 6 )  {
             QDate d( year, mon, day );  //CHECK: it was mon-1, Jan->0 (??)
             QTime t( hour, min, sec );


[prev in list] [next in list] [prev in thread] [next in thread]