[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/work/kdab-post-4.0/kdepim/kleopatra/kgpgconf
From:       Frank Osterfeld <frank () kdab ! net>
Date:       2007-10-30 10:54:33
Message-ID: 200710301154.33923.frank () kdab ! net
[Download RAW message or body]

On Tuesday 30 October 2007 11:38:14 you wrote:
> On Tuesday October 30 2007 11:06, Frank Osterfeld wrote:
> > +            assert( lst[6].startsWith( '\"') );
> > +            entry->setValueFromRawString( lst[6].mid( 1 ) );
>
> You can't assert() on format of external input. Throw an exception instead,
> and report an error to the user, but don't abort the program :)

Yes, I am aware of that. The code from qgpgmecryptoconfig uses assertions in 
some places and kWarning in others. So I kept that style when modifying the 
parser.
But I think there is no way around introducing proper error handling ;)

-- 
Frank Osterfeld -- frank@kdab.net
Klarälvdalens Datakonsult AB, Platform-independent software solutions

[prev in list] [next in list] [prev in thread] [next in thread]