[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdegraphics/kolourpaint/imagelib/effects
From:       "Clarence Dang" <dang () kde ! org>
Date:       2007-10-28 21:48:33
Message-ID: 1af2c7bd0710281448n26839e78v82c236946b313e38 () mail ! gmail ! com
[Download RAW message or body]

I don't have SVN access at the moment but the correct fix is to:


A. Revert my -r729785


AND


B. Change "24" to "32" in QPixmap kpPixmapFX::flip (const QPixmap &pm,
bool horz, bool vert):

trunk/KDE/kdegraphics/kolourpaint/imagelib/effects/kpEffectReduceColors.cpp:
819 :     newQImage = kpEffectReduceColors::convertImageDepth (
820 :     newQImage, 24/*new depth*/, false/*no dither*/);

to

819 :     newQImage = kpEffectReduceColors::convertImageDepth (
820 :     newQImage, 32/*new depth*/, false/*no dither*/);


Then, test that flipping still works.  If it does, commit.


On 10/26/07, Clarence Dang <dang@kde.org> wrote:
> SVN commit 729785 by dang:
>
> Make flip work on 24-bit screens.  I think:
>
> r725704 | dang | 2007-10-16 15:17:16 +1000 (Tue, 16 Oct 2007) | 4 lines
>
> was wrong.
>
>
>  M  +1 -0      kpEffectReduceColors.cpp
>
>
> --- trunk/KDE/kdegraphics/kolourpaint/imagelib/effects/kpEffectReduceColors.cpp #729784:729785
> @@ -53,6 +53,7 @@
>         return QImage::Format_Indexed8;
>
>     // 24-bit is known as 32-bit with QImage.
> +    case 24:  // TODO: Why is this needed for flip on a 24-bit screen?
>     case 32:
>         // TODO: If the src image has no mask, we should really return RGB32, to
>         //       avoid introducing a mask.
>
[prev in list] [next in list] [prev in thread] [next in thread]