[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/workspace/plasma/applets/kickoff/ui
From:       "Robert Knight" <robertknight () gmail ! com>
Date:       2007-10-24 9:23:38
Message-ID: 13ed09c00710240223x57a4efe0ie41421ef191f8c20 () mail ! gmail ! com
[Download RAW message or body]

> this is extremely ugly, not only because it's a big block of colour but
> because that big block of colour is ... a block. it would look *slightly*
> better if it had rounded edges and a nice gradient to it

I agree that it does not look modern (though I disagree with
'extremely ugly'), but at least it is usable for the moment.  Once we
have a clear look in mind for the panel it will be easier to get
Kickoff styled to match.  I suspect that I will end up borrowing ideas
from the Dolphin delegate.  The whole palette might even change, who
knows.

On 24/10/2007, Aaron J. Seigo <aseigo@kde.org> wrote:
> SVN commit 728735 by aseigo:
>
> only send left/right key events up if the search edit is empty. very
> annoying to hit left/right one too many times (or just holding it down to
> get to the start/end) and have the active view change on you. arg!
>
>
>  M  +5 -11     searchbar.cpp
>
>
> --- trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/searchbar.cpp
> #728734:728735
> @@ -85,22 +85,16 @@
>  }
>  bool SearchBar::eventFilter(QObject *watched,QEvent *event)
>  {
> -    // left and right arrow key presses in the search edit which will
> -    // have no effect (because the cursor is already at the start or
> -    // end of the text) are propagated up to the parent widget
> -    //
> +    // left and right arrow key presses in the search edit when the
> +    // edit is empty are propagated up to the parent widget
>      // this allows views in the Launcher to use left and right arrows for
>      // navigation whilst the search bar still has the focus
>      if (watched == d->editWidget && event->type() == QEvent::KeyPress) {
> -        QKeyEvent *keyEvent = (QKeyEvent*)event;
> -        if (keyEvent->key() == Qt::Key_Left &&
> d->editWidget->cursorPosition()==0) {
> +        QKeyEvent *keyEvent = static_cast<QKeyEvent*>(event);
> +        if ((keyEvent->key() == Qt::Key_Left || keyEvent->key() ==
> Qt::Key_Right) &&
> +            d->editWidget->text().isEmpty()) {
>              QCoreApplication::sendEvent(this,event);
>              return true;
> -
> -        } else if (keyEvent->key() == Qt::Key_Right &&
> -                   d->editWidget->cursorPosition() ==
> d->editWidget->text().length()) {
> -            QCoreApplication::sendEvent(this,event);
> -            return true;
>          }
>      }
>      return false;
>
[prev in list] [next in list] [prev in thread] [next in thread]