[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kdeui/widgets
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2007-10-22 8:38:16
Message-ID: 200710220238.17057.aseigo () kde ! org
[Download RAW message or body]


On Friday 19 October 2007, Harri Porten wrote:
> SVN commit 727204 by porten:
>
> Was the only getting those "QTimeLine::start: already running" warnings
> all the time?

the warning is actually pretty lame since it's not all that uncommon to want 
to make sure that the animation is running without restarting it, and calling 
start() more than once in a row is a no-op.

> The code might have actually been leaking QObject timers. 

of course not. =) if you look at the code in QTimeLine::start() you'll see 
that it just harmlessly return;s

and yes, your later commit is actually the "correct" fix (even if all it 
really does is get rid of a warning on the command line), as we don't want to 
restart the animation at all but continue it from where it commenced so that 
it fades in/out or out/in (or in/in or out/out in case of a really fast 
user ;) smoothly.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]